Introduce microdump_stackwalk comand line executable

Introduce microdump_stackwalk comand line executable

This introduces the microdump_stackwalk binary which takes advantage
of the MicrodumpProcessor to symbolize microdumps.
Its operation is identical to the one of minidump_stackwalk.
This CL, in fact, is also refactoring most of the common bits into
stackwalk_common.

BUG=chromium:410294
R=mmandlis@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1405

[primiano]

There we go: all the pieces coming together!

[mmandlis]

https://breakpad.appspot.com/4704002/diff/1/Makefile.am
File Makefile.am (right):

https://breakpad.appspot.com/4704002/diff/1/Makefile.am#newcode1157
Makefile.am:1157: src/processor/stackwalker_address_list.o \
it should be alphabetized, shouldn't it? please, move stackwalker_address_list
up.

https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk.cc
File src/processor/minidump_stackwalk.cc (left):

https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk....
src/processor/minidump_stackwalk.cc:140: static void PrintStack(const CallStack
*stack, const string &cpu) {
I think you forgot to upload some of your refactoring changes, I only see these
lines removed, but never added.

https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc
File src/processor/stackwalk_common.cc (right):

https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc...
src/processor/stackwalk_common.cc:703: {
Could you, please, move { to previous line?

[primiano]

https://breakpad.appspot.com/4704002/diff/1/Makefile.am
File Makefile.am (right):

https://breakpad.appspot.com/4704002/diff/1/Makefile.am#newcode1157
Makefile.am:1157: src/processor/stackwalker_address_list.o \
On 2014/11/24 17:56:00, mmandlis wrote:
> it should be alphabetized, shouldn't it? please, move stackwalker_address_list
> up.

Uh apparently this line was screwed everywhere and I just copied this over. I
fixed it everywhere.

https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk.cc
File src/processor/minidump_stackwalk.cc (left):

https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk....
src/processor/minidump_stackwalk.cc:140: static void PrintStack(const CallStack
*stack, const string &cpu) {
On 2014/11/24 17:56:00, mmandlis wrote:
> I think you forgot to upload some of your refactoring changes, I only see
these
> lines removed, but never added.
I think I moved all these to stackwalk_common.cc.
Rietveld is seeing this as a rename:
1. primiano changed minidump_stackwalk.cc (which is right): I will show the
deleted lines
2. primiano created a copy of minidump_stackwalk.cc into minidump_common.cc
(which is *kind of* true): I will show only the diff lines (but not the ones
which were copied over).
If you open stackwalk_common.cc and expand the context to "all lines" you should
see them on the right side of that file.

https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc
File src/processor/stackwalk_common.cc (right):

https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc...
src/processor/stackwalk_common.cc:703: {
On 2014/11/24 17:56:00, mmandlis wrote:
> Could you, please, move { to previous line?

Done.

[mmandlis]

lgtm

PS: sorry, i should've checked the diffs more carefully.

On 2014/11/24 18:39:30, primiano wrote:
> https://breakpad.appspot.com/4704002/diff/1/Makefile.am
> File Makefile.am (right):
> 
> https://breakpad.appspot.com/4704002/diff/1/Makefile.am#newcode1157
> Makefile.am:1157: src/processor/stackwalker_address_list.o \
> On 2014/11/24 17:56:00, mmandlis wrote:
> > it should be alphabetized, shouldn't it? please, move
stackwalker_address_list
> > up.
> 
> Uh apparently this line was screwed everywhere and I just copied this over. I
> fixed it everywhere.
> 
>
https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk.cc
> File src/processor/minidump_stackwalk.cc (left):
> 
>
https://breakpad.appspot.com/4704002/diff/1/src/processor/minidump_stackwalk....
> src/processor/minidump_stackwalk.cc:140: static void PrintStack(const
CallStack
> *stack, const string &cpu) {
> On 2014/11/24 17:56:00, mmandlis wrote:
> > I think you forgot to upload some of your refactoring changes, I only see
> these
> > lines removed, but never added.
> I think I moved all these to stackwalk_common.cc.
> Rietveld is seeing this as a rename:
> 1. primiano changed minidump_stackwalk.cc (which is right): I will show the
> deleted lines
> 2. primiano created a copy of minidump_stackwalk.cc into minidump_common.cc
> (which is *kind of* true): I will show only the diff lines (but not the ones
> which were copied over).
> If you open stackwalk_common.cc and expand the context to "all lines" you
should
> see them on the right side of that file.
> 
> https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc
> File src/processor/stackwalk_common.cc (right):
> 
>
https://breakpad.appspot.com/4704002/diff/1/src/processor/stackwalk_common.cc...
> src/processor/stackwalk_common.cc:703: {
> On 2014/11/24 17:56:00, mmandlis wrote:
> > Could you, please, move { to previous line?
> 
> Done.

[primiano]

+mark: nothing exciting in this CL. Just moving common bits of the
minidump_stackwalker.cc into a common file and introducing
microdump_stackwalker.

I don't think it's worth your time for a review, Maria took care of that.

However if you want to glance through that and you see something architecturally
wrong, feel free to shout :)

[Mark Mentovai]

Thanks for including me. This seems fine.

[primiano]

Committed patchset #3 (id:170001) manually as 1405 (presubmit successful).