Issue 452004: Make my_int_len/my_itos take uintmax_t instead of intmax_t

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 452004: Make my_int_len/my_itos take uintmax_t instead of intmax_t (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Ted Mielczarek

Modified:
11 years, 7 months ago

Reviewers:
digit

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

We changed these functions from int to intmax_t a while ago, but it turns out we
pass a size_t to this in the Mozilla codebase. The functions don't handle
negative integers anyway, so we might as well use uintmax_t.

Patch Set 2 : Renamed functions #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/minidump_writer/linux_ptrace_dumper.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/common/linux/linux_libc_support.cc	View	1	1 chunk	+7 lines, -8 lines	0 comments	Download
M	src/common/linux/linux_libc_support.h	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/common/linux/linux_libc_support_unittest.cc	View	1	1 chunk	+23 lines, -17 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

digit

http://breakpad.appspot.com/452004/diff/1/src/common/linux/linux_libc_support.h File src/common/linux/linux_libc_support.h (right): http://breakpad.appspot.com/452004/diff/1/src/common/linux/linux_libc_support.h#newcode57 src/common/linux/linux_libc_support.h:57: extern unsigned my_int_len(uintmax_t i); Wouldn't it make sense to ...

11 years, 7 months ago #2

Ted Mielczarek

11 years, 7 months ago #3

lgtm

Expand All Messages | Collapse All Messages