Issue 444003: Add MinidumpContext::GetInstructionPointer helper method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 444003: Add MinidumpContext::GetInstructionPointer helper method (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by Ted Mielczarek

Modified:
11 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

I found this patch laying around in my patch queue. I can't remember the exact
motivation, but I write a lot of single-purpose tools for minidump inspection,
so it was probably useful for something.

Patch Set 1 #

Patch Set 2 : Use in some unit tests #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/handler/exception_handler_unittest.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/client/mac/tests/exception_handler_test.cc	View	1	3 chunks	+3 lines, -42 lines	0 comments	Download
M	src/client/windows/unittests/exception_handler_death_test.cc	View	1	3 chunks	+3 lines, -33 lines	0 comments	Download
M	src/google_breakpad/processor/minidump.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/processor/minidump.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/processor/minidump_unittest.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ted Mielczarek

11 years, 7 months ago #4

Doesn't warrant another review, but I realized that I could make immediate use
of this in a bunch of unit tests.

Expand All Messages | Collapse All Messages