Enable breakpad_unittests on Android

Enable breakpad_unittests on Android

This patch is based on the fix in https://breakpad.appspot.com/434002/
and https://breakpad.appspot.com/433002/.

Fixed various build issue and can run breakpad_unittests successfully
with 5 failed cases(totally 55 cases).

BUG=

[James Wei (wistoch)]

This patch works with digit's patch together.

[James Wei (wistoch)]

+digit

[yfriedman]

I'm not the right person to review this. Added digit/mark

[Mark Mentovai]

David’s been working heavily in this area, I’d like to hear what he has to say
about this first.

[digit]

I hope to have an upcoming patch to address the same issues.

http://breakpad.appspot.com/435003/diff/1/common/linux/tests/crash_generator.cc
File common/linux/tests/crash_generator.cc (right):

http://breakpad.appspot.com/435003/diff/1/common/linux/tests/crash_generator....
common/linux/tests/crash_generator.cc:55: #if !defined(__ANDROID__)
I'd recommend implementing pthread_barrier_t at the fron of this source file,
e.g.:

  namespace {

  #if defined(__ANDROID__)
  # if !defined(__BIONIC_HAVE_PTHREAD_BARRIER_T)
  typedef struct {
    pthread_cond_t cond;
    pthread_mutex_t mutex;
    int count;
  } pthread_barrier_t;

  int pthread_barrier_init(...) { ... }
  int pthread_barrier_wait(...) { ... }
  #endif  // !__BIONIC_HAVE_PTHREAD_BARRIER_T

  #if !defined(__BIONIC_HAVE_PTHREAD_YIELD)
  void inline pthread_yield(void) {
    sched_yield();
  }
  #endif  // !__BIONIC_HAVE_PTHREAD_YIELD
  #endif  // __ANDROID__

This way, you'll avoid modifying the rest of the code and will keep everything
much clearer. Personally, I've solved this by placing the implementation in a
different file and providing a custom <pthread.h> in
src/common/android/include/, but a direct modification should work too. I'll let
Mark decide which coding/structe style he prefers.

http://breakpad.appspot.com/435003/diff/1/common/tests/auto_tempdir.h
File common/tests/auto_tempdir.h (right):

http://breakpad.appspot.com/435003/diff/1/common/tests/auto_tempdir.h#newcode47
common/tests/auto_tempdir.h:47: // Android does not declare mkdtemp even though
it's implemented.
It's not exposed by the NDK, which means it's not necessarily part of an
OEM-customized device, so don't assume this will always work.

Chromium does provide its own implementation, which is why this links with it,
but for the upstream project, this is not enough. It's better to add a custom
implementation here, or in another file.

[James Wei (wistoch)]

On 2012/08/21 16:13:53, digit wrote:
> I hope to have an upcoming patch to address the same issues.
> 
>
http://breakpad.appspot.com/435003/diff/1/common/linux/tests/crash_generator.cc
> File common/linux/tests/crash_generator.cc (right):
> 
>
http://breakpad.appspot.com/435003/diff/1/common/linux/tests/crash_generator....
> common/linux/tests/crash_generator.cc:55: #if !defined(__ANDROID__)
> I'd recommend implementing pthread_barrier_t at the fron of this source file,
> e.g.:
> 
>   namespace {
> 
>   #if defined(__ANDROID__)
>   # if !defined(__BIONIC_HAVE_PTHREAD_BARRIER_T)
>   typedef struct {
>     pthread_cond_t cond;
>     pthread_mutex_t mutex;
>     int count;
>   } pthread_barrier_t;
> 
>   int pthread_barrier_init(...) { ... }
>   int pthread_barrier_wait(...) { ... }
>   #endif  // !__BIONIC_HAVE_PTHREAD_BARRIER_T
> 
>   #if !defined(__BIONIC_HAVE_PTHREAD_YIELD)
>   void inline pthread_yield(void) {
>     sched_yield();
>   }
>   #endif  // !__BIONIC_HAVE_PTHREAD_YIELD
>   #endif  // __ANDROID__
> 
> This way, you'll avoid modifying the rest of the code and will keep everything
> much clearer. Personally, I've solved this by placing the implementation in a
> different file and providing a custom <pthread.h> in
> src/common/android/include/, but a direct modification should work too. I'll
let
> Mark decide which coding/structe style he prefers.
> 
> http://breakpad.appspot.com/435003/diff/1/common/tests/auto_tempdir.h
> File common/tests/auto_tempdir.h (right):
> 
>
http://breakpad.appspot.com/435003/diff/1/common/tests/auto_tempdir.h#newcode47
> common/tests/auto_tempdir.h:47: // Android does not declare mkdtemp even
though
> it's implemented.
> It's not exposed by the NDK, which means it's not necessarily part of an
> OEM-customized device, so don't assume this will always work.
> 
> Chromium does provide its own implementation, which is why this links with it,
> but for the upstream project, this is not enough. It's better to add a custom
> implementation here, or in another file.

digit, it is fine to use your solution if you already have a better solutions in
downstream. 

thanks

[digit]

For the record, my own patch to fix the same issue was submitted as r1020 (see
http://breakpad.appspot.com/439002/).

I have also uploaded a Chromium patch at
(https://chromiumcodereview.appspot.com/10875048) which is currently on the
trybots.

[digit]

Breakpad passes 100% of the client library unit tests on Android/ARM and
Android/x86 now. I think this path is not necessary anymore. Can I ask you to
close it?

Thanks.

[James Wei (wistoch)]

On 2012/09/05 09:50:16, digit wrote:
> Breakpad passes 100% of the client library unit tests on Android/ARM and
> Android/x86 now. I think this path is not necessary anymore. Can I ask you to
> close it?
> 
> Thanks.

sure. I will close it. thanks