Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 426003: Support relative paths in android/run-checks.sh

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by digit
Modified:
11 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Support relative paths in android/run-checks.sh

This patch updates the script to ensure that parameters
passed to the --ndk-dir and --adb option can contain relative
paths instead of absolute ones.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M android/run-checks.sh View 4 chunks +51 lines, -0 lines 2 comments Download

Messages

Total messages: 2
Ted Mielczarek
LGTM https://breakpad.appspot.com/426003/diff/1/android/run-checks.sh File android/run-checks.sh (right): https://breakpad.appspot.com/426003/diff/1/android/run-checks.sh#newcode270 android/run-checks.sh:270: (cd "$1" &>/dev/null && pwd 2>/dev/null) || echo ...
11 years, 7 months ago #1
Mark Mentovai
11 years, 7 months ago #2
https://breakpad.appspot.com/426003/diff/1/android/run-checks.sh
File android/run-checks.sh (right):

https://breakpad.appspot.com/426003/diff/1/android/run-checks.sh#newcode261
android/run-checks.sh:261: # Convert a path to its absolute version (unless it
is invalid)
This only works on directories that exist. Document that. And name it
dir_absolute_path too, to make it somewhat self-documenting.

Or…

Make it smarter by splitting the argument into basename and dirname, doing the
cd on the dirname, and then appending the basename. Since this function will
ultimately be used to build an absolute path to a file, not a directory, that
will concentrate the logic here in this function, allowing absolute_command_path
to focus on other things.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted