On 2015/02/03 23:46:16, Lei Zhang (chromium) wrote:
> . o O (We probably should add tests for this)
>
> I'll look into adding a bigger test for testing the .gnu_debuglink
> functionality.
Thanks for writing this! Touching that code was painful. I would like to have
some more tests in dump_symbols_unittest.cc, but they're a pain to write because
you need to generate plausible ELF and DWARF test data. That file already has a
synthetic ELF generator based on the TestAssembler code (and tests that generate
symbol tables), and dwarf2reader_die_unittest.cc has some code for generating
synthetic DWARF, so it might not be too bad to leverage all that into generating
a full test of the dump_symbols code.
Issue 3774002: Add unit tests for overlapping functions and externs.
(Closed)
Created 9 years, 11 months ago by Lei Zhang (chromium)
Modified 9 years, 11 months ago
Reviewers: Mark Mentovai, Ted Mielczarek
Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Comments: 0