Issue 3774002: Add unit tests for overlapping functions and externs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 3774002: Add unit tests for overlapping functions and externs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by Lei Zhang (chromium)

Modified:
9 years, 12 months ago

Reviewers:
Mark Mentovai, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add unit tests for overlapping functions and externs.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1424

Patch Set 1 #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/module_unittest.cc	View		1 chunk	+68 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

. o O (We probably should add tests for this) I'll look into adding a ...

9 years, 12 months ago #1

Ted Mielczarek

9 years, 12 months ago #4

Message was sent while issue was closed.

On 2015/02/03 23:46:16, Lei Zhang (chromium) wrote:
> . o O (We probably should add tests for this)
> 
> I'll look into adding a bigger test for testing the .gnu_debuglink
> functionality.

Thanks for writing this! Touching that code was painful. I would like to have
some more tests in dump_symbols_unittest.cc, but they're a pain to write because
you need to generate plausible ELF and DWARF test data. That file already has a
synthetic ELF generator based on the TestAssembler code (and tests that generate
symbol tables), and dwarf2reader_die_unittest.cc has some code for generating
synthetic DWARF, so it might not be too bad to leverage all that into generating
a full test of the dump_symbols code.

Expand All Messages | Collapse All Messages