Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 3764002: Add a unit test for generating a minidump from a core dump on Linux.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Ben Chan
Modified:
2 years, 1 month ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add a unit test for generating a minidump from a core dump on Linux.

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 1 3 chunks +26 lines, -0 lines 3 comments Download

Messages

Total messages: 4
Ben Chan
2 years, 1 month ago #1
vapier
https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right): https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc#newcode768 src/client/linux/minidump_writer/minidump_writer_unittest.cc:768: return; shouldn't there be an ASSERT here instead of ...
2 years, 1 month ago #2
Ben Chan
https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right): https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc#newcode768 src/client/linux/minidump_writer/minidump_writer_unittest.cc:768: return; On 2015/02/02 18:23:12, vapier wrote: > shouldn't there ...
2 years, 1 month ago #3
vapier
2 years, 1 month ago #4
lgtm

https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_wri...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_wri...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:768: return;
it might be breakpad's fault :)

i tried grepping for existing examples before posting but failed to find any. 
many my grep wasn't doing what i thought it was.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted