Issue 3764002: Add a unit test for generating a minidump from a core dump on Linux.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 3764002: Add a unit test for generating a minidump from a core dump on Linux.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 2 months ago by Ben Chan

Modified:
9 years, 2 months ago

Reviewers:
vapier, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add a unit test for generating a minidump from a core dump on Linux.

Patch Set 2 : #

Total comments: 3

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View	1	3 chunks	+26 lines, -0 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

vapier

https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right): https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_writer/minidump_writer_unittest.cc#newcode768 src/client/linux/minidump_writer/minidump_writer_unittest.cc:768: return; shouldn't there be an ASSERT here instead of ...

9 years, 2 months ago #2

Ben Chan

9 years, 2 months ago #3

vapier

9 years, 2 months ago #4

lgtm

https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_wri...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/3764002/diff/30001/src/client/linux/minidump_wri...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:768: return;
it might be breakpad's fault :)

i tried grepping for existing examples before posting but failed to find any. 
many my grep wasn't doing what i thought it was.

Expand All Messages | Collapse All Messages