Issue 359001: Remove static initializer in linux/guid_creator.cc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 359001: Remove static initializer in linux/guid_creator.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by pliard

Modified:
12 years, 2 months ago

Reviewers:
qsr, pliard

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove static initializer in linux/guid_creator.cc.

There was a static initializer generated for this file in Chrome for Android.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/guid_creator.cc	View		4 chunks	+16 lines, -8 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

pliard_google.com

Yes that would be great thanks! Please make sure that it builds correctly in breakpad ...

12 years, 2 months ago #4

qsr

Commited with review: http://breakpad.appspot.com/359002/ pliard: Can you close this issue?

12 years, 2 months ago #5

pliard

12 years, 2 months ago #6

On 2012/03/08 18:48:21, qsr wrote:
> Commited with review: http://breakpad.appspot.com/359002/
> 
> pliard: Can you close this issue?

Thanks for the quick review and submit!

Expand All Messages | Collapse All Messages