Demangle symbol name

Demangle symbol name

The spec says it should be demangled.
https://code.google.com/p/google-breakpad/wiki/SymbolFiles

BUG=chromium:453498
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1421

[hashimoto]

Could you review this?

[Mark Mentovai]

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
File src/common/linux/elf_symbols_to_module.cc (right):

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
src/common/linux/elf_symbols_to_module.cc:159: std::string name =
SymbolString(iterator->name_offset, strings);
Why introduce name as a temporary when ext->name will do the trick?

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
src/common/linux/elf_symbols_to_module.cc:162: char* demangled =
abi::__cxa_demangle(name.c_str(), NULL, NULL, &status);
dwarf_cu_to_module.cc avoids this on Android. There must be a reason for that.

[hashimoto]

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
File src/common/linux/elf_symbols_to_module.cc (right):

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
src/common/linux/elf_symbols_to_module.cc:159: std::string name =
SymbolString(iterator->name_offset, strings);
On 2015/01/30 13:22:21, Mark Mentovai wrote:
> Why introduce name as a temporary when ext->name will do the trick?

I thought it might be better to split demangling code and Module::Extern set up
code.
Replaced name with ext->name.

https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_m...
src/common/linux/elf_symbols_to_module.cc:162: char* demangled =
abi::__cxa_demangle(name.c_str(), NULL, NULL, &status);
On 2015/01/30 13:22:21, Mark Mentovai wrote:
> dwarf_cu_to_module.cc avoids this on Android. There must be a reason for that.

According to https://breakpad.appspot.com/521002/, Android NDK provides
cxxabi.h, but not abi::__cxa_demangle.

Added comments and #ifdef.

[Mark Mentovai]

LGTM

[hashimoto]

Committed patchset #2 (id:50001) manually as r1421 (presubmit successful).