Issue 2694002: Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in newer NDKs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 2694002: Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in newer NDKs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rmcilroy

Modified:
10 years, 6 months ago

Reviewers:
Mark Mentovai, qsr1

CC:
qsr, anton

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in
newer NDKs

BUG=346626
TBR=mark@chromium.org

Committed: 1331

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	common/android/include/sys/user.h	View		1 chunk	+8 lines, -3 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

qsr1

LGTM with nit. https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h File common/android/include/sys/user.h (right): https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h#newcode149 common/android/include/sys/user.h:149: // changing lots of Bionic, uUse ...

10 years, 6 months ago #2

rmcilroy

10 years, 6 months ago #4

Message was sent while issue was closed.

https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h
File common/android/include/sys/user.h (right):

https://breakpad.appspot.com/2694002/diff/1/common/android/include/sys/user.h...
common/android/include/sys/user.h:149: // changing lots of Bionic, uUse an ugly
macro renaming trick with
On 2014/05/14 09:49:23, qsr1 wrote:
> s/uU/s/

Opps missed this - done in https://breakpad.appspot.com/3674002/

Expand All Messages | Collapse All Messages