Issue 2654002: Clean up common.gypi.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 2654002: Clean up common.gypi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by chrisha

Modified:
10 years, 7 months ago

Reviewers:
mmentovai, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Clean up common.gypi.

This removes a handful of redundant variables and GYP includes.

BUG=
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1321

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/build/common.gypi	View	11 chunks	+55 lines, -232 lines	0 comments	Download
D	src/build/external_code.gypi	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	src/build/internal/release_defaults.gypi	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	src/build/internal/release_impl.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	src/build/internal/release_impl_official.gypi	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	src/build/release.gypi	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r1321 (presubmit successful).

Expand All Messages | Collapse All Messages