Issue 1764002: Remove pointers from serialized file format

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1764002: Remove pointers from serialized file format (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by mdempsky

Modified:
9 years, 11 months ago

Reviewers:
Lei Zhang (chromium)

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove pointers from serialized file format

BUG=breakpad:621
R=thestig@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1410

Patch Set 1 #

Patch Set 2 : Use ElfW(Addr) instead of void* to be consistent #

Patch Set 3 : Add minidump_type_helper.h #

Patch Set 4 : Remove unnecessary 'typename' keyword #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1 2	5 chunks	+9 lines, -5 lines	0 comments	Download
A	src/common/minidump_type_helper.h	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/google_breakpad/common/minidump_format.h	View		2 chunks	+28 lines, -10 lines	0 comments	Download
M	src/tools/linux/md2core/minidump-2-core.cc	View	1 2 3	5 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mdempsky

On 2014/12/08 21:33:19, Lei Zhang (chromium) wrote: > lgtm Thanks for the quick review. How ...

9 years, 11 months ago #3

Message was sent while issue was closed.

Committed patchset #4 (id:100001) manually as r1410 (presubmit successful).

Expand All Messages | Collapse All Messages