[Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation.

[Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

__system_property_get has been removed from the Android NDK for 'L' so Breakpad
no longer links. This CL just removes the call in WriteOSInformation because
Chrome already passes the build fingerprint as a crash key called
"android_build_fp" in the crash report HTTP POST message.

BUG=394841,393903
R=mark@chromium.org

Committed: 1351

[rmcilroy]

Mark, could you please review this?  

It is required in order to fix the arm64/x86_64 builder bots (e.g.:
http://build.chromium.org/p/chromium.fyi/builders/Android%20ARM64%20Builder%2...).

Thanks.

[Mark Mentovai]

Your CL description says

> we already pass the build fingerprint in the "android_build_fp" minidump field
> in Chrome.

This is confusing to me. Does this mean that we’re still getting the fingerprint
string somehow in Chrome? Are we losing this information from the minidump
totally?

[rmcilroy]

On 2014/07/18 12:45:36, Mark Mentovai wrote:
> Your CL description says
> 
> > we already pass the build fingerprint in the "android_build_fp" minidump
field
> > in Chrome.
> 
> This is confusing to me. Does this mean that we’re still getting the
fingerprint
> string somehow in Chrome? Are we losing this information from the minidump
> totally?

The fingerprint is added to the crash report as a key here:
https://code.google.com/p/chromium/codesearch#chromium/src/components/breakpa...

I just generated a crash with this CL applied locally and the crash report is
here:
https://crash.corp.google.com/browse?q=reportid=%272b3b3c71325e3699%27#2

In the Product data section it has the fingerprint listed under
"android_build_fp", however the fingerprint is no longer appended to "OS Name,
version".  Does this make sense?  Is this ok?

[Mark Mentovai]

That sounds OK, but the description is confusing because you’re talking about
what Chrome calls a “crash key”, which is delivered as part of the HTTP POST
data. Saying it’s a minidump field misled me into thinking that it was being
stuck into the minidump file somehow, but that’s not the case. Can you make the
description clearer?

LGTM

[rmcilroy]

On 2014/07/18 13:06:54, Mark Mentovai wrote:
> That sounds OK, but the description is confusing because you’re talking about
> what Chrome calls a “crash key”, which is delivered as part of the HTTP POST
> data. Saying it’s a minidump field misled me into thinking that it was being
> stuck into the minidump file somehow, but that’s not the case. Can you make
the
> description clearer?
> 
> LGTM

Ahh, sorry I was confused thinking the keys were added to the minidump - I
didn't realize these were separate HTTP POST keys.  I'll update the description.

[rmcilroy]

Committed patchset #1 manually as r1351 (presubmit successful).

[Ted Mielczarek]

This kind of sucks because it makes other consumers lose this information. Is
there no way to get it from C++ at all now?

[rmcilroy]

On 2014/07/18 16:08:37, Ted Mielczarek wrote:
> This kind of sucks because it makes other consumers lose this information. Is
> there no way to get it from C++ at all now?

Unfortunately not, the system_properties_get function was never intended to be a
public API in Android, and the Android team are removing it from 'L'. The best
solution is probably to use Build.FINGERPRINT
(http://developer.android.com/reference/android/os/Build.html#FINGERPRINT) in
Java ahead of time and pass it down via JNI when initializing breakpad (this is
what Chrome does)