Issue 1684002: Allow build on VS2010 and VS2012

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1684002: Allow build on VS2010 and VS2012

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by mkato

Modified:
10 years, 4 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Allow build on VS2010 and VS2012

BUG=584

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/windows/pdb_source_line_writer.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Ted Mielczarek

10 years, 4 months ago #1

https://breakpad.appspot.com/1684002/diff/1/src/common/windows/pdb_source_lin...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/1684002/diff/1/src/common/windows/pdb_source_lin...
src/common/windows/pdb_source_line_writer.cc:43: #undef max
Can't we #define NOMINMAX instead?

Expand All Messages | Collapse All Messages