Issue 1644002: Linux: Check the CRC32 of the debug link file in the symbol dumper.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1644002: Linux: Check the CRC32 of the debug link file in the symbol dumper. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Lei Zhang (chromium)

Modified:
10 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Linux: Check the CRC32 of the debug link file in the symbol dumper.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1320

Patch Set 2 : do a better job of searching through multiple directories #

Total comments: 5

Patch Set 3 : #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	Makefile.am	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	Makefile.in	View		12 chunks	+28 lines, -2 lines	0 comments	Download
A	src/common/linux/crc32.cc	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
A	src/common/linux/crc32.h	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	src/common/linux/dump_symbols.cc	View	1	10 chunks	+52 lines, -23 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM! https://breakpad.appspot.com/1644002/diff/30001/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode465 Makefile.am:465: src/common/linux/crc32.cc \ Sort: c < d https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode514 Makefile.am:514: ...

10 years, 7 months ago #2

Lei Zhang (chromium)

https://breakpad.appspot.com/1644002/diff/30001/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode465 Makefile.am:465: src/common/linux/crc32.cc \ On 2014/04/23 13:31:50, Mark Mentovai wrote: > ...

10 years, 7 months ago #3

Message was sent while issue was closed.

Committed patchset #3 manually as r1320 (presubmit successful).

Expand All Messages | Collapse All Messages