Issue 1624003: Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1624003: Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rmcilroy

Modified:
10 years, 7 months ago

Reviewers:
Lei Zhang (chromium)

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is
dumped.

On certain versions of Android (specifically JellyBean MR2 on Nexus 7, possibly
others too) no ELF core dump is created for crashing processes.  Check for this
and skip the test if so.

BUG=364943
R=thestig@chromium.org

Committed: 1318

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/minidump_writer/linux_core_dumper_unittest.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	common/linux/elf_core_dump_unittest.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r1318 (presubmit successful).

Expand All Messages | Collapse All Messages