Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 1584002: minidump-2-core: Allow user to override shared lib basedir. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Lei Zhang (chromium)
Modified:
10 years, 2 months ago
Reviewers:
kouhei
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

minidump-2-core: Allow user to override shared lib basedir.

This CL introduces "--sobasedir" command-line option to minidump-2-core.
By default, paths to shared lib files included in generated core file are
formatted as "/var/lib/breakpad/[GUID]libFoobar.so". By using "--sobasedir",
this will be "[user-supplied-path]libFoobar.so".

This option can be used to ease debugging minidump files from developer's local
builds. By specifying "minidump-2-core --sobasedir `pwd`/out/Debug/lib/
foobar.mdmp", user can load the generated core file in gdb without setting up
the symlinks for "/var/lib/breakpad".

BUG=None
A=kouhei@chromium.org

Original code review: https://breakpad.appspot.com/1214002/

R=kouhei@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/tools/linux/md2core/minidump-2-core.cc View 6 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
10 years, 2 months ago #1
kouhei
lgtm
10 years, 2 months ago #2
Lei Zhang (chromium)
10 years, 2 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1317 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted