Move build configuration to root of repository.

Move build configuration to root of repository.

This is in preparation for creating GYP build files for each platform.

BUG=https://code.google.com/p/google-breakpad/issues/detail?id=575
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1304

[chrisha]

PTAL

[Mark Mentovai]

https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi#newcode1326
build/common.gypi:1326: 
Get rid of the blank line at the end of this file, and other files in this
change.

https://breakpad.appspot.com/1414002/diff/20001/build/external_code.gypi
File build/external_code.gypi (right):

https://breakpad.appspot.com/1414002/diff/20001/build/external_code.gypi#newc...
build/external_code.gypi:1: # Copyright 2010 Google Inc. All rights reserved.
I don’t think anything uses this file.

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi
File build/release.gypi (right):

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi#newcode4
build/release.gypi:4: ['buildtype=="Dev"', {
I don’t think Breakpad really needs to distinguish between “dev” and
“official” release builds. I’d think that we’d just want to use the “official”
settings everywhere.

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi#newcode5
build/release.gypi:5: 'includes': ['internal/release_impl.gypi'],
This is a little silly. Let’s get rid of the files in internal and just put them
inline, right here.

Actually, I don’t really know that we even need this file, as opposed to just
putting everything inline into common.gypi.

[chrisha]

This CL simply moves the existing 'build' directory. While I agree that
common.gypi and its includes need to be *drastically* simplified, I'd prefer to
do that in a separate CL.

I'd argue for keeping a Debug build profile as well, however. The symbol
accuracy is drastically different between Debug and Release/Official, and makes
development easier.

https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://breakpad.appspot.com/1414002/diff/20001/build/common.gypi#newcode1326
build/common.gypi:1326: 
On 2014/04/03 15:58:19, Mark Mentovai wrote:
> Get rid of the blank line at the end of this file, and other files in this
> change.

Done.

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi
File build/release.gypi (right):

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi#newcode4
build/release.gypi:4: ['buildtype=="Dev"', {
On 2014/04/03 15:58:19, Mark Mentovai wrote:
> I don’t think Breakpad really needs to distinguish between “dev” and
> “official” release builds. I’d think that we’d just want to use the
“official”
> settings everywhere.

It's on my todo list to simplify common.gypi and its includes. This has been
copied blatantly from an older version of Chrome and contains all sorts of
garbage. I wanted to do that in a separate CL.

https://breakpad.appspot.com/1414002/diff/20001/build/release.gypi#newcode5
build/release.gypi:5: 'includes': ['internal/release_impl.gypi'],
On 2014/04/03 15:58:19, Mark Mentovai wrote:
> This is a little silly. Let’s get rid of the files in internal and just put
them
> inline, right here.
> 
> Actually, I don’t really know that we even need this file, as opposed to just
> putting everything inline into common.gypi.

Ditto. Wanted to move this in one CL, clean it up in another.

[Mark Mentovai]

> I'd argue for keeping a Debug build profile as well, however. The symbol
> accuracy is drastically different between Debug and Release/Official,
> and makes development easier.

Yes, absolutely keep a Debug configuration. I was saying that we should get rid
of the distinction between Release and Official Release. That’s not useful for
Breakpad.

Smaller, bite-sized CLs are good. LGTM.

[chrisha]

On 2014/04/03 18:28:10, Mark Mentovai wrote:
> > I'd argue for keeping a Debug build profile as well, however. The symbol
> > accuracy is drastically different between Debug and Release/Official,
> > and makes development easier.
> 
> Yes, absolutely keep a Debug configuration. I was saying that we should get
rid
> of the distinction between Release and Official Release. That’s not useful for
> Breakpad.

Mea culpa for misreading that :) I agree regarding the official/release
distinction.

> Smaller, bite-sized CLs are good. LGTM.

Thanks, committing now.

[chrisha]

Committed patchset #2 manually as r1304 (presubmit successful).

[ivanpe]

On 2014/04/03 18:35:10, chrisha wrote:
> Committed patchset #2 manually as r1304 (presubmit successful).

Chris, I have a problem with the directory name that you have chosen: 'build'. 
In Google, our build files are normally called 'BUILD' and we have such a file
in this exact same location.  No action is required at this time as I'm
attempting to move our BUILD file somewhere else (probably under src/).  This is
just a heads up in case I need to rename it.

[ivanpe]

On 2014/04/09 22:31:19, ivanpe wrote:
> On 2014/04/03 18:35:10, chrisha wrote:
> > Committed patchset #2 manually as r1304 (presubmit successful).
> 
> Chris, I have a problem with the directory name that you have chosen: 'build'.

> In Google, our build files are normally called 'BUILD' and we have such a file
> in this exact same location.  No action is required at this time as I'm
> attempting to move our BUILD file somewhere else (probably under src/).  This
is
> just a heads up in case I need to rename it.

I tried to move our BUILD file.  Everything compiles fine and all tests are
passing however I started seeing the following build WARNING: 

//depot/google3/third_party/breakpad:
	Some but not all of BUILD, LICENSE, OWNERS, README.google were removed.

Apparently the expectation is to have all these files in the same location.  I
can continue moving files around but I'm thinking maybe it will be better to
chose a different name or location for the 'build' directory?

Any suggestions?

(1) I can move the 'build' directory under src/ ?
(2) Or rename it to 'bld' ?

Or, I can move the LICENSE file under src and take care for the other google
specific files but I feel that options (1) or (2) will be better.

[Mark Mentovai]

Leave the BUILD file alone and move the build directory.

[ivanpe]

On 2014/04/09 23:47:56, Mark Mentovai wrote:
> Leave the BUILD file alone and move the build directory.

Sounds good.  I'll send a CL shortly.  Thanks.