Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(375)

Issue 1144002: Add dump_syms for DWARF symbols in a PECOFF image, as used by cygwin and mingw

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by j.turney
Modified:
2 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add dump_syms for DWARF symbols in a PECOFF image, as used by cygwin and mingw

For the cygwin target, build a dump_syms tool which can read DWARF symbols
contained in a PE/COFF executable.

I felt a bit bad about just making another copy of dump_symbols.cc, so this one
is parameterized by an image file reader class, and then applied to a
pecoff-format image file reading class.

The  pecoff image file reader:
- knows how to read PE32 and PE32+ image files
- makes a PECOFF file id by fetching it from a CV record or by hashing
- can read PECOFF exports as a fallback if there is no DWARF information

Patch Set 1 #

Patch Set 2 : Add dump_syms for DWARF symbols in a PECOFF image, as used by cygwin and mingw #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 3 chunks +29 lines, -0 lines 0 comments Download
M configure.ac View 1 1 chunk +5 lines, -0 lines 0 comments Download
A src/common/pecoff/dump_symbols-inl.h View 1 chunk +706 lines, -0 lines 0 comments Download
A src/common/pecoff/dump_symbols.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A src/common/pecoff/dump_symbols.h View 1 chunk +80 lines, -0 lines 0 comments Download
A src/common/pecoff/pecoff.h View 1 chunk +262 lines, -0 lines 0 comments Download
A src/common/pecoff/pecoff_file_id.cc View 1 chunk +83 lines, -0 lines 0 comments Download
A src/common/pecoff/pecoff_file_id.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/common/pecoff/pecoffutils.cc View 1 1 chunk +492 lines, -0 lines 0 comments Download
A src/common/pecoff/pecoffutils.h View 1 1 chunk +167 lines, -0 lines 0 comments Download
A src/tools/windows/dump_syms_dwarf/dump_syms.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 5
j.turney
3 years, 4 months ago #1
Ted Mielczarek
Hi there, I'll try to find someone to review your patch. Just a few procedural ...
3 years, 2 months ago #2
jon.turney
On 08/04/2014 14:36, ted.mielczarek@gmail.com wrote: > I'll try to find someone to review your patch. ...
3 years, 2 months ago #3
Ted Mielczarek
Mark: can you find someone to review this patch? I don't have the bandwidth for ...
3 years, 1 month ago #4
j.turney
2 years, 4 months ago #5
Small update

Fix compilation by updating use of Module::Extern() to match change in r1415
Fix some -Werror=sign-compare errors arising due to signedness of size_t
Fix export table fallback to match reality rather than PE/COFF spec.
Properly swap endianess of buildid UUID
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted