Issue 1114003: Expose ExceptionHandler::HandleSignal for use in non-breakpad signal handlers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1114003: Expose ExceptionHandler::HandleSignal for use in non-breakpad signal handlers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by Jed Davis

Modified:
10 years ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Make ExceptionHandler::HandleSignal public, for use in non-breakpad signal
handlers — for example, Gecko's seccomp-bpf integration includes a SIGSYS
handler from which it would be useful to create a crash dump with the original
signal context.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/handler/exception_handler.h	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Ted Mielczarek

10 years, 9 months ago #1

This LGTM.

For reference, the upstream Mozilla bug is
https://bugzilla.mozilla.org/show_bug.cgi?id=945498 .

Expand All Messages | Collapse All Messages