Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 1014002: Don't crash when no __debug_info section is found

Can't Edit
Can't Publish+Mail
Start Review
7 years, 6 months ago by mcuelenaere
7 years, 6 months ago
Base URL:


DumpSymbols::ReadDwarf() currently assumes a __debug_info section is always
present and crashes if there isn't one (through using an assert).

Gracefully handle this by returning false if the section isn't present.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/mac/dump_syms.mm View 1 chunk +6 lines, -1 line 0 comments Download


Total messages: 1
Lei Zhang (chromium)
7 years, 6 months ago #1
Thanks for doing this. If you can sign the CLA per
https://code.google.com/p/google-breakpad/wiki/ContributingToBreakpad, I'd be
happy to commit this for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted