Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Results

Newer ›

	Subject	Owner	Reviewers	Comments	Last updated
1704002	Cherry pick r1344 into chrome_37 branch (Closed)	rmcilroy	Mark Mentovai		9 years, 10 months
1694003	Cleanup: Remove Mac 10.5 macros. (Closed)	Lei Zhang (chromium)	Mark Mentovai	1	9 years, 10 months
6694002	Both std::tr1::unordered_set and std::unordered_set are not allowed in (Closed)	ivanpe	Mark Mentovai, mmandlis, earthdok, uekawa	2	9 years, 10 months
10664002	Add frame pointer recovery to the AMD64 Stackwalker. (Closed)	rsesek	Mark Mentovai	7	9 years, 10 months
7694002	Change some ELF utils to return the length as a size_t. (Closed)	Lei Zhang (chromium)	Mark Mentovai		9 years, 10 months
1684002	Allow build on VS2010 and VS2012	mkato	Ted Mielczarek	1	9 years, 10 months
2714002	dump_syms: use unordered_set<> instead of set<> for speed.	uekawa	Mark Mentovai, earthdok	2	9 years, 10 months
6674002	Cleanup: hide undefined behavior from the compiler better. (Closed)	ivanpe	Ted Mielczarek, jcivelli, qsr, Mark Mentovai, digit		9 years, 10 months
9664002	Unhook current Breakpad object after handling uncaught NSException. (Closed)	pkl	qsr		9 years, 10 months
10654002	Update output for test minidump_dump_test. (Closed)	ivanpe	Mark Mentovai		9 years, 11 months
5674002	minidump_dump: convert time_t values to UTC correctly. Interpret the (Closed)	Mark Mentovai	ivanpe	9	9 years, 11 months
7664002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos	ivanpe		9 years, 11 months
3694002	Add missing MD_MISCINFO_FLAGS1_BUILDSTRING (Closed)	Mark Mentovai	ivanpe	1	9 years, 11 months
8654002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos			9 years, 11 months
6664002	minidump_dump: Display x86 CPU vendor string for x86_64	Mark Mentovai	Ted Mielczarek		9 years, 11 months
3684002	Linux: Fix a memory leak in ExceptionHandler. (Closed)	Lei Zhang (chromium)	Mark Mentovai		9 years, 12 months
2704002	Fix a memory leak in DwarfCUToModule::FuncHandler::Finish(). (Closed)	Lei Zhang (chromium)	Mark Mentovai		9 years, 12 months
3664002	[MIPS] Fix core dump related unit tests for Android on MIPS (Closed)	gordanac	Ivan Penkov, digit, Mark Mentovai, Ben Chan	6	10 years
2684002	[Mac] Remove unused host_info call and supporting calls (Closed)	Mark Mentovai	blundell, qsr	2	10 years
6654002	Fix the documentation for MinidumpFileWriter::Open(). (Closed)	Lei Zhang (chromium)	Mark Mentovai		10 years

Newer ›