Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 461 - 480 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
360001	Add SIGABRT handler for mac and iOS. (Closed)	qsr	Mark Mentovai, ted, qsr1	4	14 years, 4 months
359001	Remove static initializer in linux/guid_creator.cc. (Closed)	pliard	qsr, pliard		14 years, 4 months
359002	Remove static initializer in linux/guid_creator.cc. (Closed)	qsr			14 years, 4 months
357001	Removing breakpad_exc_server and all references. (Closed)	qsr	Mark Mentovai		14 years, 4 months
354001	Cast result of _dyld_image_count to prevent compilation warning. (Closed)	qsr	Mark Mentovai	2	14 years, 4 months
355001	Send uptime as milliseconds for Mac and iOS. (Closed)	qsr	Mark Mentovai	8	14 years, 4 months
352001	Handle stackwalking programs with the assignment operator smashed against the next token (Closed)	bsmedberg	Ted Mielczarek, Mark Mentovai, jimb	3	14 years, 5 months
349003	Support for .raSearch in the x86 stack walker (Closed)	bsmedberg	Ted Mielczarek, mmentovai, Mark Mentovai	5	14 years, 5 months
353001	Modify CrashGenerator::CreateChildCrash to copy proc files. (Closed)	Ben Chan	Michael Krebs		14 years, 5 months
353002	Fix an invalid cast in PostfixEvaluator<ValueType>::EvaluateInternal(). (Closed)	Ben Chan	Ted Mielczarek, bsmedberg, Mark Mentovai		14 years, 5 months
349002	Support @ (alignment) operator in PostfixEvaluator (Closed)	Ted Mielczarek	Mark Mentovai	2	14 years, 5 months
351001	Move away from the 10.4 SDK (Closed)	Mark Mentovai	thakis	1	14 years, 5 months
350001	Handle bootstrap_register deprecation (Closed)	Mark Mentovai	thakis	1	14 years, 5 months
107001	Issue 384 - UnregisterWait error handling is incorrect (Closed)	bsmedberg	doshimun		14 years, 5 months
229001	Mac breakpad should use internal MD5 implementation (Closed)	bsmedberg	Ted Mielczarek		14 years, 5 months
347002	Add missing include. (Closed)	qsr	stuartmorgan, stuart.morgan		14 years, 5 months
347001	Creating minidump for uncaught exception on iOS. (Closed)	qsr	Mark Mentovai	50	14 years, 5 months
343003	Breakpad DWARF: Add support for DWARF 4 attribute forms. (Closed)	jimb	Ted Mielczarek, Lei Zhang (chromium)	1	14 years, 6 months
343002	Breakpad DWARF support: Remove extraneous breaks following returns in dwarf2reader.cc. (Closed)	jimb	Ted Mielczarek		14 years, 6 months
342002	Add partial unit tests for dwarf2reader::CompilationUnit. (Closed)	jimb	Ted Mielczarek	4	14 years, 6 months

« Newest ‹ Newer 461 - 480 Older ›