Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 261 - 280 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
594002	Fix a "set but not used" compiler warning in libdisasm (Closed)	mseaborn	Mark Mentovai		12 years, 7 months
583003	Fix following r1175: the section name is __debug_info, not .debug_info (Closed)	Mark Mentovai	Lei Zhang (chromium)		12 years, 7 months
584002	Check in new Windows binaries. (Closed)	chrisha	Siggi, Mark Mentovai		12 years, 7 months
593002	Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling. (Closed)	Lei Zhang (chromium)	Mark Mentovai	4	12 years, 7 months
592002	Fix mac dump_syms after r1163. (Closed)	Lei Zhang (chromium)	Mark Mentovai, icodestuff	2	12 years, 7 months
593003	NULL-check the entry in NonAllocatingMap before setting on it. (Closed)	rsesek	Mark Mentovai	4	12 years, 7 months
565002	Add an option to not handle DWARF inter-compilation unit references in Linux dump_syms. (Closed)	Lei Zhang (chromium)	jimb, icodestuff	9	12 years, 7 months
591002	Make x86-64 stack walking work for Native Client minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		12 years, 7 months
590002	Add MD_OS_NACL platform_id value for identifying NaCl minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		12 years, 7 months
588003	Fix an "unused variable" compiler warning in exploitability_win.cc (Closed)	mseaborn	Mark Mentovai		12 years, 7 months
588002	Fix GetLoadingAddress() to work for Native Client executables (Closed)	mseaborn	Mark Mentovai, Roland McGrath	1	12 years, 7 months
583002	Fix minidump generation from exception. (Closed)	qsr	Mark Mentovai		12 years, 7 months
580003	Make LinuxDumper::FindMapping return an iterator instead of a pointer (Closed)	glandium	Ted Mielczarek		12 years, 7 months
579002	Add GYP file for tools\windows\symupload. (Closed)	chrisha	Siggi, Mark Mentovai		12 years, 7 months
570002	Add explicit OMAP support to dump_syms. (Closed)	chrisha	Siggi, Mark Mentovai	27	12 years, 7 months
572003	Find auvx entries in process memory instead of /proc/pid/auxv (Closed)	glandium	Ted Mielczarek		12 years, 8 months
576002	Fixing a clang warning. (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess, iwilkins		12 years, 8 months
574002	Add MD_OS_PS3 to breakpad and exception types. (Closed)	Lei Zhang (chromium)	jijia		12 years, 8 months
569002	Fix Clang warning regarding null pointer argument. Fix provided by Ian Wilkinson. (Closed)	Ivan Penkov	iwilking, Mark Mentovai, Ted Mielczarek, Jess, iwilkins	2	12 years, 8 months
572002	Cleanup: Use scoped_ptr where appropriate in DwarfCUToModule. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 8 months

« Newest ‹ Newer 261 - 280 Older ›