Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 241 - 260 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
612002	Linux: Fix builds on systems without PR_SET_PTRACER in linux/prctl.h. (Closed)	Lei Zhang (chromium)	thakis	2	11 years, 9 months
611002	Fix Android build more. (Closed)	Lei Zhang (chromium)	thakis, Mark Mentovai		11 years, 9 months
581002	Use std::vector with a custom allocator wrapping PageAllocator for wasteful_vector (Closed)	glandium	Ted Mielczarek, thakis	1	11 years, 9 months
608002	Fix a clang warning (Closed)	Mark Mentovai	thakis		11 years, 9 months
36001	Implement a network daemon + networked implementation of SymbolSupplier and SourceLineResolver (Closed)	Ted Mielczarek	jimb, Mark Mentovai, thakis	29	11 years, 9 months
606002	Stackwalker sees invalid stack memory for the thread (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess, mmandlis1	14	11 years, 9 months
605002	More robust stack walks when EIP in the context frame is invalid (ot not in a known module). (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess, mmandlis1	10	11 years, 10 months
604002	Eliminate redundant initialization (Closed)	Mark Mentovai	ivanpe.google, Ivan Penkov		11 years, 10 months
603002	ficl (Closed)	tfarina			11 years, 10 months
602002	add interface for WriteMinidump which allows the caller to supply file handles instead of paths whe… (Closed)	Cris Neckar	Mark Mentovai, ivanpe.google, Ivan Penkov	8	11 years, 10 months
513002	Remove <(library) usage from gyp files. (Closed)	tfarina	Lei Zhang (chromium)		11 years, 10 months
601002	Fixing level 4 warnings (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess, sorin, mmandlis1	20	11 years, 10 months
599002	Bug in wasteful_vector page allocator (Closed)	Ivan Penkov	mattdr, Mark Mentovai, Ted Mielczarek, glandium	10	11 years, 11 months
598002	Regenerating configure using a newer version of autoconf. (Closed)	Ivan Penkov	Mark Mentovai, Jess, Ted Mielczarek, Lei Zhang (chromium)		11 years, 11 months
597002	Fixing two std::vector::operator[] out of range accesses (Closed)	Ivan Penkov	Mark Mentovai, Jess, Ted Mielczarek, digit		11 years, 11 months
586003	Make custom info population before dump generation as an optional operation (Closed)	Ivan Penkov	xiaolingbao, Jess, Mark Mentovai	3	11 years, 11 months
582002	Ensure a proper LinuxDumper::crash_thread_ value (Closed)	glandium	Ted Mielczarek		11 years, 11 months
585002	Fix build failure in functioninfo.cc (Closed)	glandium	Ted Mielczarek		11 years, 11 months
577002	Compile issue when using global string "::string" (Closed)	Ivan Penkov	digit, Mark Mentovai, Jess		11 years, 11 months
592003	Fix a "set but not used" compiler warning in a test (Closed)	mseaborn	Mark Mentovai	2	11 years, 11 months

« Newest ‹ Newer 241 - 260 Older ›