Issue 9754002: Fix some fragile code that is likely to cause future memory corruption problems.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by erikchen

Modified:
9 years, 10 months ago

Reviewers:

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Fix some fragile code that is likely to cause future memory corruption problems.

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/dwarf_cu_to_module.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/common/linux/elf_symbols_to_module.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/common/module.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/common/module.h	View	4 chunks	+11 lines, -4 lines	0 comments	Download
M	src/common/module_unittest.cc	View	8 chunks	+17 lines, -29 lines	0 comments	Download
M	src/common/stabs_to_module.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download