Issue 9694002: Back out trunk r1367

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 9694002: Back out trunk r1367 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by Mark Mentovai

Modified:
10 years, 2 months ago

Reviewers:
primiano, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Back out trunk r1367.

Compile error: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091#c15

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1369

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/windows/sender/crash_report_sender.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/client/windows/sender/crash_report_sender.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/common/linux/http_upload.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/common/linux/http_upload.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/common/windows/http_upload.cc	View	4 chunks	+28 lines, -28 lines	0 comments	Download
M	src/common/windows/http_upload.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

LGTM and tested that now builds on Linux.

Expand All Messages | Collapse All Messages