Issue 964002: Switch scoped_ptr.h to a compatible google3 implementation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 964002: Switch scoped_ptr.h to a compatible google3 implementation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by Lei Zhang (chromium)

Modified:
10 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Switch scoped_ptr.h to a compatible google3 implementation.

This is Chromium's base/memory/scoped_ptr.h at r98718, which split off
from the google3 version at a later point than Breakpad's copy. It is a
drop in replacement and the only changes are:
- removal of WARN_UNUSED_RESULT.
- moving it into the google_breakpad namespace.

BUG=534
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1265

Patch Set 2 : #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/scoped_ptr.h	View	1	2 chunks	+273 lines, -204 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM https://breakpad.appspot.com/964002/diff/1/src/common/scoped_ptr.h File src/common/scoped_ptr.h (right): https://breakpad.appspot.com/964002/diff/1/src/common/scoped_ptr.h#newcode60 src/common/scoped_ptr.h:60: #ifndef BASE_MEMORY_SCOPED_PTR_H_ Fix the guards.

10 years, 11 months ago #2

Lei Zhang (chromium)

https://breakpad.appspot.com/964002/diff/1/src/common/scoped_ptr.h File src/common/scoped_ptr.h (right): https://breakpad.appspot.com/964002/diff/1/src/common/scoped_ptr.h#newcode60 src/common/scoped_ptr.h:60: #ifndef BASE_MEMORY_SCOPED_PTR_H_ On 2013/12/18 16:53:55, Mark Mentovai wrote: > ...

10 years, 11 months ago #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1265 (presubmit successful).

Expand All Messages | Collapse All Messages