Windows: Fix remaining level 4 warnings.

Windows: Fix remaining level 4 warnings.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1267

[Lei Zhang (chromium)]

Not sure why Ivan didn't get these on the last pass.

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
File src/tools/windows/symupload/symupload.cc (right):

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
src/tools/windows/symupload/symupload.cc:180: return printUsageAndExit();
The compiler doesn't understand this exits and thinks |module| from line 168 may
be uninitialized on line 186.

[Mark Mentovai]

https://breakpad.appspot.com/954002/diff/1/src/common/windows/pdb_source_line...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/954002/diff/1/src/common/windows/pdb_source_line...
src/common/windows/pdb_source_line_writer.cc:393: DWORD last_type =
static_cast<DWORD>(-1);
DWORD_MAX instead of ugly static_casts?

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
File src/tools/windows/symupload/symupload.cc (right):

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
src/tools/windows/symupload/symupload.cc:180: return printUsageAndExit();
But it’s odd to return a void value from a function that’s supposed to return an
int.

Instead of returning here, does it help to decorate printUsageAndExit with
__declspec(noreturn)?

[Mark Mentovai]

LGTM

[Lei Zhang (chromium)]

https://breakpad.appspot.com/954002/diff/1/src/common/windows/pdb_source_line...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/954002/diff/1/src/common/windows/pdb_source_line...
src/common/windows/pdb_source_line_writer.cc:393: DWORD last_type =
static_cast<DWORD>(-1);
On 2013/12/18 16:50:30, Mark Mentovai wrote:
> DWORD_MAX instead of ugly static_casts?

DWORD_MAX doesn't exist. Would you prefer 0xFFFFFFFF instead?

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
File src/tools/windows/symupload/symupload.cc (right):

https://breakpad.appspot.com/954002/diff/1/src/tools/windows/symupload/symupl...
src/tools/windows/symupload/symupload.cc:180: return printUsageAndExit();
On 2013/12/18 16:50:30, Mark Mentovai wrote:
> But it’s odd to return a void value from a function that’s supposed to return
an
> int.
> 
> Instead of returning here, does it help to decorate printUsageAndExit with
> __declspec(noreturn)?

That works. Thanks.

[Mark Mentovai]

From <limits>, std::numeric_limits<DWORD>::max() then?

[Lei Zhang (chromium)]

On 2013/12/18 22:06:44, Mark Mentovai wrote:
> From <limits>, std::numeric_limits<DWORD>::max() then?

Done.

[Lei Zhang (chromium)]

Committed patchset #3 manually as r1267 (presubmit successful).