Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 944002: Fix warnings from the Windows build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by Lei Zhang (chromium)
Modified:
10 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix warnings from the Windows build.

These warnings are fatal in my GYP-generated debug build.
The warnings can be seen on Linux/Mac with -Wshorten-64-to-32.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1264

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/minidump.cc View 2 chunks +10 lines, -2 lines 3 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
https://breakpad.appspot.com/944002/diff/1/src/processor/minidump.cc File src/processor/minidump.cc (left): https://breakpad.appspot.com/944002/diff/1/src/processor/minidump.cc#oldcode606 src/processor/minidump.cc:606: context_flags_ = context_flags; We just set |context_flags_| on line ...
10 years, 11 months ago #1
Mark Mentovai
Wow, Breakpad’s been on fire lately. LGTM. https://breakpad.appspot.com/944002/diff/1/src/processor/minidump.cc File src/processor/minidump.cc (right): https://breakpad.appspot.com/944002/diff/1/src/processor/minidump.cc#newcode680 src/processor/minidump.cc:680: context_flags_ = ...
10 years, 11 months ago #2
Lei Zhang (chromium)
10 years, 11 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1264 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted