Issue 914002: Making the Mac build of crash_report work again after the last SVN sync. This includes correction o…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 914002: Making the Mac build of crash_report work again after the last SVN sync. This includes correction o… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by Ivan Penkov

Modified:
10 years, 11 months ago

Reviewers:
tschweitzer, Mark Mentovai, Lei Zhang (chromium), nealsid

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Making the Mac build of crash_report work again after the last SVN sync. This
includes correction of a method definition signature and adding missing code
files to the project.

I'm commiting this on behalf of Thomas Schweitzer.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1261

Patch Set 1 #

Patch Set 2 : #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/tools/mac/crash_report/crash_report.xcodeproj/project.pbxproj	View		5 chunks	+26 lines, -0 lines	0 comments	Download
	M	src/tools/mac/crash_report/on_demand_symbol_supplier.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages