Issue 884002: disable unittests under ASAN that use memory crashes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 884002: disable unittests under ASAN that use memory crashes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by vapier

Modified:
10 years, 11 months ago

Reviewers:
Lei Zhang (chromium), Ted Mielczarek, Ben Chan

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

disable unittests under ASAN that use memory crashes

There are a bunch of tests that use invalid memory acesses (on purpose)
to trigger a crash so that we can detect things are dumped correctly.
When we run under ASAN, it catches those accesses and the breaks the
testing flow.

For now, use the existing ADDRESS_SANITIZER symbol to disable more tests.
Ideally we'd use a compile-time attribute to disable ASAN on a few funcs,
but that seems to be broken atm.

BUG=chromium:293519
BUG=chromium:304575
TEST=ran unittests under ASAN and they now pass
TEST=ran unittests w/out asan/clang and they still pass
R=benchan@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1255

Patch Set 1 #

Patch Set 2 : #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/breakpad_googletest_includes.h	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/exception_handler_unittest.cc	View		8 chunks	+14 lines, -5 lines	0 comments	Download
M	src/client/windows/unittests/exception_handler_death_test.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r1255 (presubmit successful).

Expand All Messages | Collapse All Messages