Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(507)

Issue 864003: Use AM_MAINTAINER_MODE so configure supports --enable-maintainer-mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by Roland McGrath
Modified:
10 years, 3 months ago
Reviewers:
bradnelson, Mark Mentovai, Ted Mielczarek, mcgrathr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Use AM_MAINTAINER_MODE so configure supports --enable-maintainer-mode

When AM_MAINTAINER_MODE is not used in configure.ac, automake
generates a Makefile.in that unconditionally includes rules to
rebuild Makefile.in from Makefile.am, configure from configure.ac,
etc.  As these generated files are kept in the repository, the
effect is that anyone doing a simple checkout; configure; make is
likely to get these regeneration rules run just by the luck of the
draw based on the relative timestamps of Makefile.am and Makefile.in
from the checkout (svn and git give checked-out files a timestamp of
"now").  When these rules trigger, they require that automake,
autoconf, etc. be installed, and they can sometimes require that
they match the versions used to generate the files in the
repository.  This is generally poor practice for distributed source
packages.  With AM_MAINTAINER_MODE, the generated configure script
supports a --enable-maintainer-mode switch; when that switch is not
given, these rules are suppressed so they can never cause mischief
for people just doing the build.  People actually making changes to
configure.ac, Makefile.am, etc. can do use --enable-maintainer-mode
so that their builds regenerate things as needed.

After making this one-line change to configure.ac, I ran the command
"autoreconf -f -i" on a Goobuntu Precise workstation.  All the
changes except for configure.ac itself are from that.  This has
regenerated everything consistently using Autoconf 2.68 and Automake
1.11.3.  Since no configure.ac or Makefile.am file gives a
particular version requirement, I presume it doesn't much matter to
Breakpad which versions are used.  In general, it does matter to
make sure that all the generated files, and all the files copied by
-i (--missing) behavior, are from matching versions.  The state of
files in the repository shows that people have been doing partial
regenerations for years, which is a bad idea.  As long as it's going
to have the generated files in the repo (which is good IMHO for
various reasons), then the project should pick canonical versions
that everything modifying the repo will use, and people making
changes to any autoconf or automake input files should run
"autoreconf -f -i" and include the generated-file changes in the
same CL.

R=bradnelson@google.com, mark@chromium.org
BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M INSTALL View 12 chunks +171 lines, -35 lines 0 comments Download
M aclocal.m4 View 37 chunks +340 lines, -439 lines 0 comments Download
M autotools/compile View 3 chunks +31 lines, -68 lines 0 comments Download
M autotools/config.guess View 3 chunks +2 lines, -6 lines 0 comments Download
M autotools/config.sub View 4 chunks +2 lines, -11 lines 0 comments Download
M autotools/depcomp View 15 chunks +143 lines, -39 lines 0 comments Download
M autotools/install-sh View 11 chunks +136 lines, -116 lines 0 comments Download
M autotools/missing View 16 chunks +29 lines, -65 lines 0 comments Download
M configure View 83 chunks +415 lines, -528 lines 0 comments Download
M configure.ac View 1 chunk +1 line, -0 lines 0 comments Download
M src/config.h.in View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Roland McGrath
10 years, 3 months ago #1
bradnelson
lgtm (configure mispelled in change description).
10 years, 3 months ago #2
Roland McGrath
On 2013/12/10 00:03:24, bradnelson wrote: > lgtm (configure mispelled in change description). I'll need to ...
10 years, 3 months ago #3
Ted Mielczarek
On 2013/12/10 00:12:18, mcgrathr wrote: > On 2013/12/10 00:03:24, bradnelson wrote: > > lgtm (configure ...
10 years, 3 months ago #4
Mark Mentovai
LGTM. Are you planning to make more changes?
10 years, 3 months ago #5
Roland McGrath
On 2013/12/10 14:04:06, Mark Mentovai wrote: > LGTM. Are you planning to make more changes? ...
10 years, 3 months ago #6
Mark Mentovai
Ha. OK, let me know if you have more and I’ll put you on the ...
10 years, 3 months ago #7
Roland McGrath
On 2013/12/10 12:29:18, Ted Mielczarek wrote: > On 2013/12/10 00:12:18, mcgrathr wrote: > > On ...
10 years, 3 months ago #8
mcgrathr_google.com
On Tue, Dec 10, 2013 at 9:22 AM, <mark@chromium.org> wrote: > Ha. OK, let me ...
10 years, 3 months ago #9
Mark Mentovai
10 years, 3 months ago #10
OK, I added you as mcgrathr@chromium.org.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted