There’s no easy answer.
make only does a server processor tools build, it doesn’t build any of the
client code. There are xcodeprojs checked in to Breakpad for the client tools,
but they’re almost always out-of-date and broken. The Chromium GYP build is
pretty much authoritative. The best bet is to test your change in Chromium.
If you don’t have a full Chromium checkout, you should be able to just grab the
breakpad directory, and then check out Breakpad’s src directory as a
subdirectory of that (this is normally done by DEPS). If you run gyp on
breakpad/breakpad.gyp, combined with Chromium’s build/common.gypi, that should
give you something that works.
I’m not even sure any of this DEBUGLOG stuff is useful. Before and after your
patch, you’ve got to modify the .mm files to even use it. That’s only very
slightly better than placing temporary purpose-specific printfs when you need
them.
On 2013/12/09 15:29:19, Mark Mentovai wrote:
> I’m not even sure any of this DEBUGLOG stuff is useful. Before and after your
> patch, you’ve got to modify the .mm files to even use it. That’s only very
> slightly better than placing temporary purpose-specific printfs when you need
> them.
Ahh, so that's why I didn't catch it with make. OK, I'll try and do a gyp build
or try and get a chromium build up and running to test.
Yeah, all the DEBUGLOG stuff looks pretty hokey.
I've now tested this patch on chromium mac's build and it builds properly now.
I've had to remove one of the DEBUGLOG in Inspector.h which seemed innocuous. I
would be inclined to remove all of them if you thought it was a good idea.
On 2013/12/10 03:17:37, Mark Mentovai wrote:
> I do think it’s a good idea to dump all of them.
Removed all the DEBUGLOGs and tested this again with the Mac Chrome build.
Issue 854002: Remove usage of gDebugLog by directly using the VERBOSE preprocessor define
(Closed)
Created 11 years, 7 months ago by altse
Modified 11 years, 7 months ago
Reviewers: Mark Mentovai
Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Comments: 0
