Issue 844002: switch armv7 setting to arm_version==7 in breakpad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 844002: switch armv7 setting to arm_version==7 in breakpad (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mostynb

Modified:
10 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

switch armv7 setting to arm_version==7 in breakpad

BUG=http://crbug.com/234135

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/build/common.gypi	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 4

Mark Mentovai

LGTM I still don’t love that this stuff is in a directory named “windows” but ...

10 years, 10 months ago #2

mostynb

On 2013/12/07 21:21:29, Mark Mentovai wrote: > LGTM Thanks- can you please land this for ...

10 years, 10 months ago #3

Checked in Breakpad r1246.