Support custom URL parameters

[mochalatte]

Hi Stuart
We talked about this a little bit and I decided the best way to go was a new API
call so the application programmer wouldn't have to be aware of any custom
semantics we had to specify that a given parameter should be sent to the server.

Thanks,

Neal

[stuart.morgan]

Is it worth making it so that anything in the creation dictionary (e.g., plist)
that starts with the prefix will be sucked in automatically so that people can
put static custom values in the plist?

http://breakpad.appspot.com/8002/diff/1008/1012
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/1008/1012#newcode91
Line 91: #define BREAKPAD_URL_PARAMETER_PREFIX  "BreakpadServerParameter_"
"URL" doesn't seem like the right term (what URL? Is it really a URL parameter,
rather than post data? etc.). I'd say SERVER is probably better to use
everywhere you currently have URL.

http://breakpad.appspot.com/8002/diff/1008/1012#newcode215
Line 215: //                                parameters are sent to the server.
This is a bit confusing if you don't already know what it's for. Maybe "This
prefix is used to indicate which parameters other than those listed above that
should be uploaded to the server."?

http://breakpad.appspot.com/8002/diff/1008/1012#newcode244
Line 244: // to the crash server.  They will be automatically URL encoded for
I would just leave this more vague ("They will be automatically be encoded as
necessary") so it's less about specific implementation.

http://breakpad.appspot.com/8002/diff/1008/1012#newcode250
Line 250: // This method will remove a previously-added parameter to the URL
s/to/from/, remove the world "URL"

http://breakpad.appspot.com/8002/diff/1008/1010
File client/mac/sender/crash_report_sender.h (right):

http://breakpad.appspot.com/8002/diff/1008/1010#newcode72
Line 72: NSMutableDictionary *extraURLVars_;      // A dictionary containing
Again, s/URL/Server (in both the name and the comment).

http://breakpad.appspot.com/8002/diff/1008/1011
File client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/8002/diff/1008/1011#newcode678
Line 678: - (BOOL)setURLParametersFromDictionary:(NSMutableDictionary
*)crashParameters {
s/URL/Server/. Also, while you are renaming it, I would expect a method called
fooFromDictionary:(NSDictionary*)aDictionaryArgument to use the argument as
input, and get something from it (it confused me yesterday when I saw it called,
and I had to go read the implementation to see what it did). How about
populateServerParameterDictionary:?

http://breakpad.appspot.com/8002/diff/1008/1011#newcode702
Line 702: // Now, add the parameters that were custom added by the
Remove "custom"

http://breakpad.appspot.com/8002/diff/1008/1011#newcode718
Line 718: - (void)addCrashDumpValue:(id)value forKey:(NSString *)key {
The name doesn't make it clear that it's about the server; how about
addServerParamaterWithValue:forKey:?

http://breakpad.appspot.com/8002/diff/1008/1009
File client/mac/testapp/Controller.m (right):

http://breakpad.appspot.com/8002/diff/1008/1009#newcode238
Line 238: @"BuildID",
Maybe use something that isn't so similar to one of the explicit preset keys?

[mochalatte]

Hi Stuart
COmments addressed, and I also added a way to add server parameters statically
in the plist file(and the client doesn't even have to use our ugly prefix, too)

http://breakpad.appspot.com/8002/diff/1008/1012
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/1008/1012#newcode91
Line 91: #define BREAKPAD_URL_PARAMETER_PREFIX  "BreakpadServerParameter_"
On 2009/04/22 19:38:35, stuart.morgan wrote:
> "URL" doesn't seem like the right term (what URL? Is it really a URL
parameter,
> rather than post data? etc.). I'd say SERVER is probably better to use
> everywhere you currently have URL.

Done.

http://breakpad.appspot.com/8002/diff/1008/1012#newcode215
Line 215: //                                parameters are sent to the server.
On 2009/04/22 19:38:35, stuart.morgan wrote:
> This is a bit confusing if you don't already know what it's for. Maybe "This
> prefix is used to indicate which parameters other than those listed above that
> should be uploaded to the server."?

Done.

http://breakpad.appspot.com/8002/diff/1008/1012#newcode244
Line 244: // to the crash server.  They will be automatically URL encoded for
On 2009/04/22 19:38:35, stuart.morgan wrote:
> I would just leave this more vague ("They will be automatically be encoded as
> necessary") so it's less about specific implementation.

Done.

http://breakpad.appspot.com/8002/diff/1008/1012#newcode250
Line 250: // This method will remove a previously-added parameter to the URL
On 2009/04/22 19:38:35, stuart.morgan wrote:
> s/to/from/, remove the world "URL"

Done.

http://breakpad.appspot.com/8002/diff/1008/1010
File client/mac/sender/crash_report_sender.h (right):

http://breakpad.appspot.com/8002/diff/1008/1010#newcode72
Line 72: NSMutableDictionary *extraURLVars_;      // A dictionary containing
On 2009/04/22 19:38:35, stuart.morgan wrote:
> Again, s/URL/Server (in both the name and the comment).

Done.

http://breakpad.appspot.com/8002/diff/1008/1011
File client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/8002/diff/1008/1011#newcode678
Line 678: - (BOOL)setURLParametersFromDictionary:(NSMutableDictionary
*)crashParameters {
On 2009/04/22 19:38:35, stuart.morgan wrote:
> s/URL/Server/. Also, while you are renaming it, I would expect a method called
> fooFromDictionary:(NSDictionary*)aDictionaryArgument to use the argument as
> input, and get something from it (it confused me yesterday when I saw it
called,
> and I had to go read the implementation to see what it did). How about
> populateServerParameterDictionary:?

Done.

http://breakpad.appspot.com/8002/diff/1008/1011#newcode702
Line 702: // Now, add the parameters that were custom added by the
On 2009/04/22 19:38:35, stuart.morgan wrote:
> Remove "custom"

Done.

http://breakpad.appspot.com/8002/diff/1008/1011#newcode718
Line 718: - (void)addCrashDumpValue:(id)value forKey:(NSString *)key {
On 2009/04/22 19:38:35, stuart.morgan wrote:
> The name doesn't make it clear that it's about the server; how about
> addServerParamaterWithValue:forKey:? the 'withValue' felt off to me.

how about addServerParameter:forKey: ?

http://breakpad.appspot.com/8002/diff/1008/1009
File client/mac/testapp/Controller.m (right):

http://breakpad.appspot.com/8002/diff/1008/1009#newcode238
Line 238: @"BuildID",
On 2009/04/22 19:38:35, stuart.morgan wrote:
> Maybe use something that isn't so similar to one of the explicit preset keys?

Done.

[stuart.morgan]

The new approach to custom plist keys is much cleaner :)

http://breakpad.appspot.com/8002/diff/4017/4022
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/4017/4022#newcode228
Line 228: //				     in the dictionary if they should be
Most of this block needs to go right a space.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode229
Line 229: //				     sent, and are not present in the
s/,//

http://breakpad.appspot.com/8002/diff/4017/4022#newcode230
Line 230: //				     server-specific dictionary(basically,
Missing a space.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode233
Line 233: //				     Breakpad)
Missing a period.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode271
Line 271: NSString *value);
Why does remove take a value?

http://breakpad.appspot.com/8002/diff/4017/4023
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/4017/4023#newcode587
Line 587: // for each key, value, just call BreakpadAddUploadParameter
s/key, value/key value pair/

http://breakpad.appspot.com/8002/diff/4017/4021
File client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/8002/diff/4017/4021#newcode235
Line 235: // crash server.
How about "Adds a key/value pair to the dictionary that will be uploaded to the
crash server."?

http://breakpad.appspot.com/8002/diff/4017/4021#newcode337
Line 337: forKey:urlParameterKey];
Fix alignment.

http://breakpad.appspot.com/8002/diff/4017/4021#newcode340
Line 340: forKey:urlParameterKey];
Same.

http://breakpad.appspot.com/8002/diff/4017/4021#newcode344
Line 344: [parameters_ setObject:value ? value : data forKey:key];
Can you add parens around the "value ? value : data" ? The : makes it hard for
me to read as-is.

http://breakpad.appspot.com/8002/diff/4017/4021#newcode781
Line 781: 
Remove the spaces on this line.

http://breakpad.appspot.com/8002/diff/4017/4021#newcode859
Line 859: // crash server.
Fix comment (although it probably should just not be duplicated).

[jeremy]

A couple of high level comments:
* Could you add some unit tests for this?
* Is there any chance it might be simpler to just prefix Breakpad's internal
dict parameters with an "opt-out" string rather than changing the public APIs to
add an opt-in string?  Seems like a smaller, safer fix than rearchitecting like
this.  If you're concerned with other stuff slipping through as more internal
parameters are added, that could be addressed by a unit test.

http://breakpad.appspot.com/8002/diff/4017/4022
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/4017/4022#newcode84
Line 84: #define BREAKPAD_SERVER_PARAMETER_DICT "BreakpadServerParameters"
Should have a documentation block bellow.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode251
Line 251: // character that straddles the 255 byte limit will be mangled.
Don't think you should change this comment, the "256-1" really helped with
clarity.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode274
Line 274: void BreakpadAddLogFile(BreakpadRef ref, NSString *logPathname);
Why the new APIs?  Why not just have BreakpadSetKeyValue() and friends use the
new behavior?

http://breakpad.appspot.com/8002/diff/4017/4023
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/4017/4023#newcode590
Line 590: while (aParameter = [keyEnumerator nextObject]) {
nit: might be a little clearer to assign value to a temp variable first.

http://breakpad.appspot.com/8002/diff/4017/4023#newcode869
Line 869: @BREAKPAD_SERVER_PARAMETER_PREFIX, key];
stringByAppendingString: ?

http://breakpad.appspot.com/8002/diff/4017/4020
File client/mac/sender/crash_report_sender.h (right):

http://breakpad.appspot.com/8002/diff/4017/4020#newcode82
Line 82: // extra server vars.
Could you expand on this comment, it's not really clear what this is for without
looking at the code.

http://breakpad.appspot.com/8002/diff/4017/4021
File client/mac/sender/crash_report_sender.m (right):

http://breakpad.appspot.com/8002/diff/4017/4021#newcode328
Line 328: // If the keyname has a the BREAKPAD_SERVER_PARAMETER_PREFIX as a
perhaps:
"If the keyname is prefixed by..., "

[mochalatte]

Addressed comments, and added a unit test file for the Breakpad class

http://breakpad.appspot.com/8002/diff/4017/4022
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/4017/4022#newcode84
Line 84: #define BREAKPAD_SERVER_PARAMETER_DICT "BreakpadServerParameters"
On 2009/06/02 16:26:20, jeremy wrote:
> Should have a documentation block bellow.

Done.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode228
Line 228: //				     in the dictionary if they should be
On 2009/06/02 05:03:10, stuart.morgan wrote:
> Most of this block needs to go right a space.

Done.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode229
Line 229: //				     sent, and are not present in the
On 2009/06/02 05:03:10, stuart.morgan wrote:
> s/,//

Done.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode230
Line 230: //				     server-specific dictionary(basically,
On 2009/06/02 05:03:10, stuart.morgan wrote:
> Missing a space.

Done.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode233
Line 233: //				     Breakpad)
On 2009/06/02 05:03:10, stuart.morgan wrote:
> Missing a period.

Done.

http://breakpad.appspot.com/8002/diff/4017/4022#newcode251
Line 251: // character that straddles the 255 byte limit will be mangled.
On 2009/06/02 16:26:20, jeremy wrote:
> Don't think you should change this comment, the "256-1" really helped with
> clarity.
Woops this got deleted by accident, I added back in the 256-1 part

http://breakpad.appspot.com/8002/diff/4017/4022#newcode271
Line 271: NSString *value);
On 2009/06/02 05:03:10, stuart.morgan wrote:
> Why does remove take a value?
Removed

http://breakpad.appspot.com/8002/diff/4017/4022#newcode274
Line 274: void BreakpadAddLogFile(BreakpadRef ref, NSString *logPathname);
On 2009/06/02 16:26:20, jeremy wrote:
> Why the new APIs?  Why not just have BreakpadSetKeyValue() and friends use the
> new behavior?
Per our discussion, left as is.

[jeremy]

http://breakpad.appspot.com/8002/diff/5033/5040
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/5033/5040#newcode86
Line 86: // parameters without having to rebuild Breakpad
Should this TODO be removed seeing as this CL has a separate API for setting
Breakpad internal and user parameters?

http://breakpad.appspot.com/8002/diff/5033/5040#newcode187
Line 187: //                                should be uploaded to the server.
Could you expand on this comment a bit, also an edit to the documentation might
be good once this CL is in :)

http://breakpad.appspot.com/8002/diff/5033/5040#newcode236
Line 236: //                                   Breakpad).
How about reworking this comment a bit:
Breakpad uses the same dictionary internally to specify it's internal
configuration parameters and parameters a client program wishes to send to the
server.  This string is used internally by Breakpad to prefix user-supplied
parameter names so those can be sent to the server without leaking Breakpad's
internal values.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode259
Line 259: // if more than this number are set.
Does the 64 key/value pair limit include Breakpad's internal paramaters?

http://breakpad.appspot.com/8002/diff/5033/5040#newcode262
Line 262: void BreakpadSetKeyValue(BreakpadRef ref, NSString *key, NSString
*value);
I'm concerned that the API is a bit confusing, could you add some more comments
to the UploadParameter* methods or rename the keyvalue methods to make it
clearer they're used for setting Breakpad's internal parameters?

http://breakpad.appspot.com/8002/diff/5033/5040#newcode275
Line 275: NSString *key);
Can this function definition live on one line?

http://breakpad.appspot.com/8002/diff/5033/5041
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/5033/5041#newcode168
Line 168: filter_callback_context_(NULL) {
Should logFileCounter be initialized here too?

http://breakpad.appspot.com/8002/diff/5033/5041#newcode657
Line 657: NSLog(@"Handling!");
Debug code?, also another one bellow.

http://breakpad.appspot.com/8002/diff/5033/5038
File client/mac/tests/BreakpadFramework_Test.mm (right):

http://breakpad.appspot.com/8002/diff/5033/5038#newcode88
Line 88: [[NSMutableDictionary alloc] init];
autorelease?

http://breakpad.appspot.com/8002/diff/5033/5038#newcode101
Line 101: andThread:(mach_port_t)thread {
should andCode: be on it's own line?

http://breakpad.appspot.com/8002/diff/5033/5038#newcode107
Line 107: - (void)testBreakpadInstantiationWithRequiredParameters {
Could you add some comments about what each test is testing?

http://breakpad.appspot.com/8002/diff/5033/5038#newcode117
Line 117: // Skip setting version, so that BreakpadCreate should fail
"should fail" -> "fails."

http://breakpad.appspot.com/8002/diff/5033/5038#newcode187
Line 187: BreakpadGenerateAndSendReport(b);
Could you separate this with spaces and add a comment such as: 
// Invoke Breakpad's exception handler.

[mochalatte]

Comments addressed.

Stuart I believe this change will now break the BuildId hack I added before to
support Sorroco; you should be able to "do it right" with the new
BreakpadAddUploadParameter API.

Neal

http://breakpad.appspot.com/8002/diff/5033/5040
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/5033/5040#newcode86
Line 86: // parameters without having to rebuild Breakpad
On 2009/06/03 17:24:03, jeremy wrote:
> Should this TODO be removed seeing as this CL has a separate API for setting
> Breakpad internal and user parameters?

Done.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode187
Line 187: //                                should be uploaded to the server.
On 2009/06/03 17:24:03, jeremy wrote:
> Could you expand on this comment a bit, also an edit to the documentation
might
> be good once this CL is in :)

Done.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode236
Line 236: //                                   Breakpad).
On 2009/06/03 17:24:03, jeremy wrote:
> How about reworking this comment a bit:
> Breakpad uses the same dictionary internally to specify it's internal
> configuration parameters and parameters a client program wishes to send to the
> server.  This string is used internally by Breakpad to prefix user-supplied
> parameter names so those can be sent to the server without leaking Breakpad's
> internal values.

Done.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode259
Line 259: // if more than this number are set.
On 2009/06/03 17:24:03, jeremy wrote:
> Does the 64 key/value pair limit include Breakpad's internal paramaters?

Unfortunately, yes. Since the number of server parameters is generally pretty
small, I added a TODO for now to separate the two dictionaries.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode262
Line 262: void BreakpadSetKeyValue(BreakpadRef ref, NSString *key, NSString
*value);
On 2009/06/03 17:24:03, jeremy wrote:
> I'm concerned that the API is a bit confusing, could you add some more
comments
> to the UploadParameter* methods or rename the keyvalue methods to make it
> clearer they're used for setting Breakpad's internal parameters?

Done.

http://breakpad.appspot.com/8002/diff/5033/5040#newcode275
Line 275: NSString *key);
On 2009/06/03 17:24:03, jeremy wrote:
> Can this function definition live on one line?

Done.

http://breakpad.appspot.com/8002/diff/5033/5041
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/5033/5041#newcode168
Line 168: filter_callback_context_(NULL) {
On 2009/06/03 17:24:03, jeremy wrote:
> Should logFileCounter be initialized here too?

REmoved this unused instance variable.

http://breakpad.appspot.com/8002/diff/5033/5041#newcode657
Line 657: NSLog(@"Handling!");
On 2009/06/03 17:24:03, jeremy wrote:
> Debug code?, also another one bellow.

Done.

http://breakpad.appspot.com/8002/diff/5033/5038
File client/mac/tests/BreakpadFramework_Test.mm (right):

http://breakpad.appspot.com/8002/diff/5033/5038#newcode88
Line 88: [[NSMutableDictionary alloc] init];
On 2009/06/03 17:24:03, jeremy wrote:
> autorelease?

Done.

http://breakpad.appspot.com/8002/diff/5033/5038#newcode101
Line 101: andThread:(mach_port_t)thread {
On 2009/06/03 17:24:03, jeremy wrote:
> should andCode: be on it's own line?

Done.

http://breakpad.appspot.com/8002/diff/5033/5038#newcode107
Line 107: - (void)testBreakpadInstantiationWithRequiredParameters {
On 2009/06/03 17:24:03, jeremy wrote:
> Could you add some comments about what each test is testing?

Done.

http://breakpad.appspot.com/8002/diff/5033/5038#newcode117
Line 117: // Skip setting version, so that BreakpadCreate should fail
On 2009/06/03 17:24:03, jeremy wrote:
> "should fail" -> "fails."

Done.

http://breakpad.appspot.com/8002/diff/5033/5038#newcode187
Line 187: BreakpadGenerateAndSendReport(b);
On 2009/06/03 17:24:03, jeremy wrote:
> Could you separate this with spaces and add a comment such as: 
> // Invoke Breakpad's exception handler.

Done.

[jeremy]

LGTM

A few small nits about comments, but no need for another round of review.

http://breakpad.appspot.com/8002/diff/5045/5052
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/5045/5052#newcode184
Line 184: //                                should be uploaded to the server. 
Each
should be -> are

http://breakpad.appspot.com/8002/diff/5045/5052#newcode186
Line 186: //                                as URL parameter to the server.
How about the following instead of this sentence.

The parameters are sent as is to the crash server.  Their content isn't added to
the minidump but pass as URL parameters when uploading the minidump to the crash
server.

http://breakpad.appspot.com/8002/diff/5045/5052#newcode280
Line 280: // to the crash server.  They will be automatically encoded as
necessary.
How about adding the following:
Note that as mentioned above there are limits on both the number of keys and
their length.

http://breakpad.appspot.com/8002/diff/5045/5050
File client/mac/tests/BreakpadFramework_Test.mm (right):

http://breakpad.appspot.com/8002/diff/5045/5050#newcode116
Line 116: // Test case that the parameters mark required actually enable
Test that

[stuart.morgan]

LGTM with minor nits.

http://breakpad.appspot.com/8002/diff/5045/5052
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/5045/5052#newcode230
Line 230: //                                   track both it's internal
s/it's/its/

http://breakpad.appspot.com/8002/diff/5045/5053
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/5045/5053#newcode529
Line 529: DEBUGLOG(stderr,
These three DEBUGLOGS should all be one line each now.

http://breakpad.appspot.com/8002/diff/5045/5053#newcode536
Line 536: "Missing required version key. \n");
Stray space after the .

http://breakpad.appspot.com/8002/diff/5045/5053#newcode900
Line 900: } catch(...) {    // don't let exception leave this C API
s/exception/exceptions/

[mochalatte]

Just responding to all comments, no need for furhter review

http://breakpad.appspot.com/8002/diff/5045/5052
File client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/8002/diff/5045/5052#newcode184
Line 184: //                                should be uploaded to the server. 
Each
On 2009/06/03 20:33:22, jeremy wrote:
> should be -> are

Done.

http://breakpad.appspot.com/8002/diff/5045/5052#newcode186
Line 186: //                                as URL parameter to the server.
On 2009/06/03 20:33:22, jeremy wrote:
> How about the following instead of this sentence.
> 
> The parameters are sent as is to the crash server.  Their content isn't added
to
> the minidump but pass as URL parameters when uploading the minidump to the
crash
> server.

Done.

http://breakpad.appspot.com/8002/diff/5045/5052#newcode230
Line 230: //                                   track both it's internal
On 2009/06/03 20:39:16, stuart.morgan wrote:
> s/it's/its/

Done.

http://breakpad.appspot.com/8002/diff/5045/5052#newcode280
Line 280: // to the crash server.  They will be automatically encoded as
necessary.
On 2009/06/03 20:33:22, jeremy wrote:
> How about adding the following:
> Note that as mentioned above there are limits on both the number of keys and
> their length.

Done.

http://breakpad.appspot.com/8002/diff/5045/5053
File client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/8002/diff/5045/5053#newcode529
Line 529: DEBUGLOG(stderr,
On 2009/06/03 20:39:16, stuart.morgan wrote:
> These three DEBUGLOGS should all be one line each now.

Done.

http://breakpad.appspot.com/8002/diff/5045/5053#newcode536
Line 536: "Missing required version key. \n");
On 2009/06/03 20:39:16, stuart.morgan wrote:
> Stray space after the .

Done.

http://breakpad.appspot.com/8002/diff/5045/5053#newcode900
Line 900: } catch(...) {    // don't let exception leave this C API
On 2009/06/03 20:39:16, stuart.morgan wrote:
> s/exception/exceptions/

Done.

http://breakpad.appspot.com/8002/diff/5045/5050
File client/mac/tests/BreakpadFramework_Test.mm (right):

http://breakpad.appspot.com/8002/diff/5045/5050#newcode116
Line 116: // Test case that the parameters mark required actually enable
On 2009/06/03 20:33:22, jeremy wrote:
> Test that

Done.