Issue 7804002: WIP - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 7804002: WIP (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by hashimoto

Modified:
9 years, 9 months ago

Reviewers:

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

WIP

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/common/dwarf_cu_to_module.cc	View	1	12 chunks	+512 lines, -3 lines	0 comments	Download
M	src/common/dwarf_cu_to_module.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/common/linux/dump_symbols.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/common/mac/dump_syms.mm	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/common/module.cc	View	1	4 chunks	+50 lines, -0 lines	0 comments	Download
M	src/common/module.h	View	1	7 chunks	+40 lines, -0 lines	0 comments	Download
M	src/google_breakpad/processor/basic_source_line_resolver.h	View	1	3 chunks	+17 lines, -0 lines	0 comments	Download
M	src/google_breakpad/processor/stack_frame.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/processor/basic_source_line_resolver.cc	View	1	5 chunks	+198 lines, -7 lines	0 comments	Download
M	src/processor/basic_source_line_resolver_types.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/processor/source_line_resolver_base_types.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/processor/stackwalk_common.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_arm.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download