Issue 674002: Use scoped_array instead of inappropriate scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 674002: Use scoped_array instead of inappropriate scoped_ptr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Jess

Modified:
12 years ago

Reviewers:
Ivan Penkov, ivanpe.google, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use scoped_array instead of inappropriate scoped_ptr

Patch Set 1 #

Patch Set 2 : remove automatically generated configure file changes #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/string_conversion.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

lgtm FWIW, scoped_array no longer exists in Chromium's scoped_ptr.h. Maybe we should update our base/ ...

12 years ago #4

Ivan Penkov

Jess, please change to scoped_ptr<uint16_t[]> source_buffer. scoped_array<> is being deprecated in google3.

12 years ago #5

Lei Zhang (chromium)

On 2013/10/28 21:59:54, Ivan Penkov wrote: > Jess, please change to scoped_ptr<uint16_t[]> source_buffer. > > ...

12 years ago #6

Ivan Penkov

12 years ago #7

On 2013/10/28 22:16:06, thestig wrote:
> On 2013/10/28 21:59:54, Ivan Penkov wrote:
> > Jess, please change to scoped_ptr<uint16_t[]> source_buffer.
> > 
> > scoped_array<> is being deprecated in google3.
> 
> Does "scoped_ptr<uint16_t[]>" work for Breakpad built outside of google3?

No, I just tried it.  It doesn't work.  I'm guessing we are stuck with
scoped_array then.

LGTM

Expand All Messages | Collapse All Messages