Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(298)

Issue 6694002: Both std::tr1::unordered_set and std::unordered_set are not allowed in (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by ivanpe
Modified:
9 years, 9 months ago
Reviewers:
Mark Mentovai, mmandlis, earthdok, uekawa
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Both std::tr1::unordered_set and std::unordered_set are not allowed in
Google at this moment.  This change is implementing a workaround that
allows switching to hash_set and hash_map.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1354

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/dwarf_cu_to_module.cc View 1 chunk +1 line, -10 lines 0 comments Download
A src/common/unordered.h View 1 chunk +62 lines, -0 lines 2 comments Download

Messages

Total messages: 4
ivanpe
9 years, 9 months ago #1
Mark Mentovai
LGTM https://breakpad.appspot.com/6694002/diff/1/src/common/unordered.h File src/common/unordered.h (right): https://breakpad.appspot.com/6694002/diff/1/src/common/unordered.h#newcode50 src/common/unordered.h:50: #include <unordered_map> We should be able to use ...
9 years, 9 months ago #2
ivanpe
Committing shortly. Thanks. https://breakpad.appspot.com/6694002/diff/1/src/common/unordered.h File src/common/unordered.h (right): https://breakpad.appspot.com/6694002/diff/1/src/common/unordered.h#newcode50 src/common/unordered.h:50: #include <unordered_map> On 2014/07/21 16:21:17, Mark ...
9 years, 9 months ago #3
ivanpe
9 years, 9 months ago #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1354 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted