Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 654002: Add SIGTRAP to the handled signals on Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by jochen
Modified:
11 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add SIGTRAP to the handled signals on Linux

BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/handler/exception_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
jochen
Mark, wdyt I'm currently adding breakpad to content shell and noticed that LOG(FATAL) in debug ...
11 years, 6 months ago #1
Mark Mentovai
Does this impact breakpoints in a debugger?
11 years, 5 months ago #2
jochen
On 2013/10/25 19:45:08, Mark Mentovai wrote: > Does this impact breakpoints in a debugger? hum ...
11 years, 5 months ago #3
jochen
actually, CHECK() etc also uses DebugBreak, so it would be really nice if we had ...
11 years, 5 months ago #4
Mark Mentovai
11 years, 5 months ago #5
jochen wrote:
> On 2013/10/25 19:45:08, Mark Mentovai wrote:
> > Does this impact breakpoints in a debugger?
> 
> hum yes, int 3 also triggers sigtrap
> 
> not sure whether running in a debugger and running breakpad at the same time
> works at all?
> 
> I guess alternatively, I could change
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.cc&l=666
> to do something more radical to crash.

Instead of int3, you could make it emit ud2, which would raise SIGILL. With gcc
and clang, __builtin_trap() should give you one of those on x86 without any
inline asm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted