Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1287)

Issue 635002: In NonAllocatingMap, remove asserts around key/value length. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by rsesek
Modified:
10 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In NonAllocatingMap, remove asserts around key/value length.

Since the data is stored using strncpy they are merely advisory in debug mode.

BUG=https://code.google.com/p/chromium/issues/detail?id=298225
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/simple_string_dictionary.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/common/simple_string_dictionary_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3
rsesek
Thoughts on this? I could have clients pre-truncate the data, but since all existing clients ...
10 years, 11 months ago #1
Mark Mentovai
I guess if key_size and value_size are invisible to the clients that are setting the ...
10 years, 11 months ago #2
rsesek
10 years, 11 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1219 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted