Issue 631003: Print HTTP response code in linux/sym_upload on failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 631003: Print HTTP response code in linux/sym_upload on failure

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mattdr

Modified:
11 years, 3 months ago

Reviewers:
google-breakpad-dev, Ivan Penkov

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

HTTPUpload::SendRequest returns false for "failed" requests, which includes
non-2xx responses. Print the response code in those cases to help with
debugging.

Recreating a previous issue deleted due to my own incompetence. Sorry for the
noise.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		src/tools/linux/symupload/sym_upload.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2013/09/16 20:52:04, mattdr wrote:

LGTM

Expand All Messages | Collapse All Messages