Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1015)

Issue 619002: check for and enable Large File Support automatically (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by vapier
Modified:
10 years, 3 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

check for and enable Large File Support automatically

If you try to process a file using a 32bit build that is larger than
2GiB in size, the linux kernel will reject things:
$ strace -eopen dump_syms ./chrome ./ > chrome.sym
...
open(".//chrome.debug", O_RDONLY)       = -1 EOVERFLOW (Value too large for
defined data type)

So let's use the existing autoconf macro to check for and enable support
as need be.

We have to shift the existing m32 logic up to before we start doing
feature test macros though otherwise a simple configure won't work:
$ ./configure --enable-m32
This is because it first tests LFS and such w/out the -m32 flags.

BUG=chromium:266064
TEST=`./configure --enable-m32 && make && make check` passes
R=benchan@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1250

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M configure View 1 5 chunks +222 lines, -20 lines 0 comments Download
M configure.ac View 1 2 chunks +21 lines, -19 lines 0 comments Download
M src/config.h.in View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
vapier
10 years, 7 months ago #1
Ben Chan
lgtm
10 years, 3 months ago #2
vapier
10 years, 3 months ago #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1250 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted