Issue 612002: Linux: Fix builds on systems without PR_SET_PTRACER in linux/prctl.h.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 612002: Linux: Fix builds on systems without PR_SET_PTRACER in linux/prctl.h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by Lei Zhang (chromium)

Modified:
11 years, 2 months ago

Reviewers:
thakis

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Linux: Fix builds on systems without PR_SET_PTRACER in linux/prctl.h.

R=thakis@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1199

Patch Set 2 : fix typo #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thakis

https://breakpad.appspot.com/612002/diff/1/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right): https://breakpad.appspot.com/612002/diff/1/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc#newcode76 src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:76: #ifndef __ANDROID__ Can this be removed then?

11 years, 2 months ago #2

thakis

11 years, 2 months ago #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1199 (presubmit successful).

Expand All Messages | Collapse All Messages