Issue 610002: Fix Android build more.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 610002: Fix Android build more.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by thakis

Modified:
11 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com, Ted Mielczarek

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix Android build more.

Android doesn't have the Yama LSM, so this line isn't needed. (It doesn't
compile either.)

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thakis

Thanks! Can you commit this? On Jun 29, 2013 7:09 AM, <mark@chromium.org> wrote: > LGTM ...

11 years, 4 months ago #3

thakis

On Sat, Jun 29, 2013 at 8:24 AM, Nico Weber <thakis@chromium.org> wrote: > Thanks! Can ...

11 years, 4 months ago #4

thakis

11 years, 4 months ago #5

On Mon, Jul 1, 2013 at 10:32 AM, Nico Weber <thakis@chromium.org> wrote:

> On Sat, Jun 29, 2013 at 8:24 AM, Nico Weber <thakis@chromium.org> wrote:
>
>> Thanks! Can you commit this?
>>
> This is just to say that http://jonyiveredesignsthings.tumblr.com/ is
> still going strong.
>

But if this change could be landed, that'd be great too. I think breakpad
is the last remaining blocker for sending the next clang roll to the
trybots.

>
>
>> On Jun 29, 2013 7:09 AM, <mark@chromium.org> wrote:
>>
>>> LGTM
>>>
>>>
https://breakpad.appspot.com/**610002/<https://breakpad.appspot.com/610002/>
>>>
>>
>

Expand All Messages | Collapse All Messages