Fix a clang warning

Fix a clang warning:

../../breakpad/src/processor/tokenize.cc:65:7: error: logical not is only
applied to the left hand side of this comparison
[-Werror,-Wlogical-not-parentheses]
  if (!remaining > 0) {
      ^          ~
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses after the
'!' to evaluate the comparison first
  if (!remaining > 0) {
      ^
       (            )
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses around left
hand side expression to silence this warning
  if (!remaining > 0) {
      ^
      (         )

R=thakis@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1196

[Mark Mentovai]

The old logic did the right thing by accident. The important thing here is that
“remaining” needs to be 0 to try to snarf up the final token, because strtok
wasn’t called in the previous pass of the loop (when “remaining” was 1). The
condition as written was “if ((remaining is zero) is greater than zero)” which
is the same as just testing “remaining == 0”. Equivalently, this can just check
“if token is non-NULL,” because if execution left the loop and token is
non-NULL, remaining must necessarily be zero.

This can be either of these options

  if (token && (token = strtok_r(NULL, "\r\n", &save_ptr))) {
  if (remaining == 0 && (token = strtok_r(NULL, "\r\n", &save_ptr))) {

[thakis]

lgtm

This is exactly how my local fix for this looks too. Thanks!

[Mark Mentovai]

Wish you mentioned something about your local fix sooner! The note you left at
https://breakpad.appspot.com/36001/#msg15 suggested something different…

[thakis]

Yup, I took a real look at this today, but you sent me your change before
you could send me yours.


On Fri, Jun 28, 2013 at 1:45 PM, <mark@chromium.org> wrote:

> Wish you mentioned something about your local fix sooner! The note you
> left at
https://breakpad.appspot.com/**36001/#msg15<https://breakpad.appspot.com/3600...
something
> different…
>
> https://breakpad.appspot.com/**608002/<https://breakpad.appspot.com/608002/>
>

[thakis]

*before I could send you min


On Fri, Jun 28, 2013 at 2:55 PM, Nico Weber <thakis@chromium.org> wrote:

> Yup, I took a real look at this today, but you sent me your change before
> you could send me yours.
>
>
> On Fri, Jun 28, 2013 at 1:45 PM, <mark@chromium.org> wrote:
>
>> Wish you mentioned something about your local fix sooner! The note you
>> left at
https://breakpad.appspot.com/**36001/#msg15<https://breakpad.appspot.com/3600...
something
>> different…
>>
>> https://breakpad.appspot.com/**608002/<https://breakpad.appspot.com/608002/>
>>
>
>

[thakis]

e


On Fri, Jun 28, 2013 at 2:55 PM, Nico Weber <thakis@chromium.org> wrote:

> *before I could send you min
>
>
> On Fri, Jun 28, 2013 at 2:55 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> Yup, I took a real look at this today, but you sent me your change before
>> you could send me yours.
>>
>>
>> On Fri, Jun 28, 2013 at 1:45 PM, <mark@chromium.org> wrote:
>>
>>> Wish you mentioned something about your local fix sooner! The note you
>>> left at
https://breakpad.appspot.com/**36001/#msg15<https://breakpad.appspot.com/3600...
something
>>> different…
>>>
>>>
https://breakpad.appspot.com/**608002/<https://breakpad.appspot.com/608002/>
>>>
>>
>>
>