Fix a clang warning.

Fix a clang warning.

Since explanatoryDialogText returns something that migth be user input, this
looks like a good change anyhow.

../../breakpad/src/client/mac/sender/crash_report_sender.m:269:38:
error: format string is not a string literal (potentially insecure)
    [-Werror,-Wformat-security]
                                     [self explanatoryDialogText],
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

[thakis]

If this lgtyou, please land.

[Mark Mentovai]

https://breakpad.appspot.com/607002/diff/1/client/mac/sender/crash_report_sen...
File client/mac/sender/crash_report_sender.m (right):

https://breakpad.appspot.com/607002/diff/1/client/mac/sender/crash_report_sen...
client/mac/sender/crash_report_sender.m:273: [self explanatoryDialogText],
I think this argument and the |nil| are reversed. This argument is otherButton.

I can fix it when I check it in so you don’t have to submit a new patch, I just
wanted to double-check with you.

[thakis]

Thanks!

https://breakpad.appspot.com/607002/diff/1/client/mac/sender/crash_report_sen...
File client/mac/sender/crash_report_sender.m (right):

https://breakpad.appspot.com/607002/diff/1/client/mac/sender/crash_report_sen...
client/mac/sender/crash_report_sender.m:273: [self explanatoryDialogText],
On 2013/06/27 20:37:31, Mark Mentovai wrote:
> I think this argument and the |nil| are reversed. This argument is
otherButton.
> 
> I can fix it when I check it in so you don’t have to submit a new patch, I
just
> wanted to double-check with you.

Whoa, you're right, sorry. I made the same mistake in another file and got

../../chrome/browser/app_controller_mac.mm:663:71: error: format specifies type
'id' but the argument has type 'int' [-Werror,-Wformat]
                               waitTitle, exitTitle, explanationText, nil);
                                                                      ^~~
/Applications/Xcode5-DP2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/usr/include/MacTypes.h:90:17:
note: expanded from macro 'nil'
    #define nil NULL
                ^~~~
/Volumes/MacintoshHD2/src/chrome-git/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.4/include/stddef.h:72:18:
note: expanded from macro 'NULL'
#    define NULL __null
                 ^~~~~~
1 error generated.


That didn't happen here because this is a m (not a mm) file and NULL is defined
to a pointer in C (while it's an int in c++)

[Mark Mentovai]

Checked in r1195 (see
https://code.google.com/p/google-breakpad/source/detail?r=1195)

[thakis]

On Thu, Jun 27, 2013 at 1:56 PM, <mark@chromium.org> wrote:

> Checked in r1195 (see
>
https://code.google.com/p/**google-breakpad/source/detail?**r=1195<https://co...>
> )
>

Thanks! While there, can you also fix
https://breakpad.appspot.com/36001/#msg15 ?


>
> https://breakpad.appspot.com/**607002/<https://breakpad.appspot.com/607002/>
>

[thakis]

On Thu, Jun 27, 2013 at 2:48 PM, Nico Weber <thakis@chromium.org> wrote:

> On Thu, Jun 27, 2013 at 1:56 PM, <mark@chromium.org> wrote:
>
>> Checked in r1195 (see
>>
https://code.google.com/p/**google-breakpad/source/detail?**r=1195<https://co...>
>> )
>>
>
> Thanks! While there, can you also fix
> https://breakpad.appspot.com/36001/#msg15 ?
>

(warning text for this is:

../../breakpad/src/processor/tokenize.cc:65:7: error: logical not is only
applied to the left hand side of this comparison
[-Werror,-Wlogical-not-parentheses]
  if (!remaining > 0) {
      ^          ~
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses after
the '!' to evaluate the comparison first
  if (!remaining > 0) {
      ^
       (            )
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses around
left hand side expression to silence this warning
  if (!remaining > 0) {
      ^
      (         )

)


>
>
>>
>> https://breakpad.appspot.com/**607002/<https://breakpad.appspot.com/607002/>
>>
>
>