Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3782)

Issue 594002: Fix a "set but not used" compiler warning in libdisasm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by mseaborn
Modified:
10 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix a "set but not used" compiler warning in libdisasm

BUG=none
TEST=none apart from compiling with "-Wall -Werror"

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/third_party/libdisasm/ia32_insn.c View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
mseaborn
Although this is in third_party, fixes seem to be accepted, based on the version history.
10 years, 10 months ago #1
Mark Mentovai
LGTM
10 years, 10 months ago #2
mseaborn
10 years, 10 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1179 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted