Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling.

Mac: Fix more errors from clang to get crash_report.xcodeproj close to
compiling.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1176

[Lei Zhang (chromium)]

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
File src/tools/mac/crash_report/on_demand_symbol_supplier.mm (right):

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
src/tools/mac/crash_report/on_demand_symbol_supplier.mm:84: NSString *dataStr =
[[[NSString alloc] initWithContentsOfFile:filePath encoding:NSUTF8StringEncoding
error:&error] autorelease];
(insert no_idea_dog meme here)

[Mark Mentovai]

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
File src/tools/mac/crash_report/on_demand_symbol_supplier.mm (right):

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
src/tools/mac/crash_report/on_demand_symbol_supplier.mm:84: NSString *dataStr =
[[[NSString alloc] initWithContentsOfFile:filePath encoding:NSUTF8StringEncoding
error:&error] autorelease];
I don’t see why this change would have been necessary.

The original should also be equivalent to

  NSString *dataStr = [NSData dataWithContentsOfFile:filePath];

Could you share the compiler’s problem here?

[Lei Zhang (chromium)]

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
File src/tools/mac/crash_report/on_demand_symbol_supplier.mm (right):

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
src/tools/mac/crash_report/on_demand_symbol_supplier.mm:84: NSString *dataStr =
[[[NSString alloc] initWithContentsOfFile:filePath encoding:NSUTF8StringEncoding
error:&error] autorelease];
On 2013/05/08 13:14:22, Mark Mentovai wrote:
> I don’t see why this change would have been necessary.
> 
> The original should also be equivalent to
> 
>   NSString *dataStr = [NSData dataWithContentsOfFile:filePath];
> 
> Could you share the compiler’s problem here?

initwithcontentsoffile deprecated, it said. Should I just use NSString *dataStr
= [NSData dataWithContentsOfFile:filePath]; here?

[Mark Mentovai]

Funny, the docs don't say it's deprecated. Does -dataWithContentsOfFile:
work?
On May 8, 2013 1:42 PM, <thestig@chromium.org> wrote:

>
> https://breakpad.appspot.com/**593002/diff/1/src/tools/mac/**
>
crash_report/on_demand_symbol_**supplier.mm<https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_demand_symbol_supplier.mm>
> File
src/tools/mac/crash_report/on_**demand_symbol_supplier.mm<http://on_demand_symbol_supplier.mm>(right):
>
> https://breakpad.appspot.com/**593002/diff/1/src/tools/mac/**
>
crash_report/on_demand_symbol_**supplier.mm#newcode84<https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_demand_symbol_supplier.mm#newcode84>
>
src/tools/mac/crash_report/on_**demand_symbol_supplier.mm:84<http://on_demand_symbol_supplier.mm:84>:
> NSString
> *dataStr = [[[NSString alloc] initWithContentsOfFile:**filePath
> encoding:NSUTF8StringEncoding error:&error] autorelease];
> On 2013/05/08 13:14:22, Mark Mentovai wrote:
>
>> I don’t see why this change would have been necessary.
>>
>
>  The original should also be equivalent to
>>
>
>     NSString *dataStr = [NSData dataWithContentsOfFile:**filePath];
>>
>
>  Could you share the compiler’s problem here?
>>
>
> initwithcontentsoffile deprecated, it said. Should I just use NSString
> *dataStr = [NSData dataWithContentsOfFile:**filePath]; here?
>
> https://breakpad.appspot.com/**593002/<https://breakpad.appspot.com/593002/>
>

[Lei Zhang (chromium)]

On 2013/05/08 17:49:52, Mark Mentovai wrote:
> Funny, the docs don't say it's deprecated. Does -dataWithContentsOfFile:
> work?

The error is:
src/tools/mac/crash_report/on_demand_symbol_supplier.mm:83:31: error:
'initWithContentsOfFile:' is deprecated [-Werror,-Wdeprecated-declarations]
        NSString *dataStr = [[[NSString alloc] initWithContentsOfFile:filePath]
autorelease];

Shows up on Stack Overflow a few times.

dataWithContentsOfFile:filePath compiles.

[Mark Mentovai]

LGTM with that change then. But I wonder what’s going on. It’s not marked
deprecated in the NSData.h header either.

[Mark Mentovai]

Oh, wait, hold on, it’s an NSString, not NSData.

[Mark Mentovai]

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
File src/tools/mac/crash_report/on_demand_symbol_supplier.mm (right):

https://breakpad.appspot.com/593002/diff/1/src/tools/mac/crash_report/on_dema...
src/tools/mac/crash_report/on_demand_symbol_supplier.mm:84: NSString *dataStr =
[[[NSString alloc] initWithContentsOfFile:filePath encoding:NSUTF8StringEncoding
error:&error] autorelease];
Since it’s NSString and not NSData, use

  NSString *dataStr = [NSString stringWithContentsOfFile:filePath
encoding:NSUTF8StringEncoding error:NULL];

You don’t need to pass an NSError** if you’re not interested in the error, NULL
is OK.

[Lei Zhang (chromium)]

ok, can you look at patch set 2?

[Mark Mentovai]

LGTM.

[Lei Zhang (chromium)]

Committed patchset #2 manually as r1176 (presubmit successful).