Fix a "set but not used" compiler warning in a test

Fix a "set but not used" compiler warning in a test

Add a missing assertion whose absence made the test ineffective.
Make the test a little stricter too.

BUG=none
TEST="make check" to run the test + use "-Wall -Werror"

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1180

[Mark Mentovai]

LGTM. Adding this is up to you. I know you’re just trying to fix the compile
error.

https://breakpad.appspot.com/592003/diff/1/src/client/linux/minidump_writer/l...
File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right):

https://breakpad.appspot.com/592003/diff/1/src/client/linux/minidump_writer/l...
src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:90: break;
Perhaps this shouldn’t break but continue looping to make sure that the TID
doesn’t show up in the list more than once, like

  EXPECT_FALSE(found);

before setting found = true.

[mseaborn]

https://breakpad.appspot.com/592003/diff/1/src/client/linux/minidump_writer/l...
File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right):

https://breakpad.appspot.com/592003/diff/1/src/client/linux/minidump_writer/l...
src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:90: break;
On 2013/05/10 19:25:36, Mark Mentovai wrote:
> Perhaps this shouldn’t break but continue looping to make sure that the TID
> doesn’t show up in the list more than once, like
> 
>   EXPECT_FALSE(found);
> 
> before setting found = true.

Done.

[Mark Mentovai]

Now that’s a good test. LGTM.

[mseaborn]

Committed patchset #2 manually as r1180 (presubmit successful).